Linux wireless drivers development
 help / color / mirror / Atom feed
From: drago01 <drago01@gmail.com>
To: "Tomas Winkler" <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
	yi.zhu@intel.com, linux-wireless@vger.kernel.org,
	"Emmanuel Grumbach" <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 1/1] mac80211: don't accept WEP keys other than WEP40 and WEP104
Date: Sat, 28 Jun 2008 08:46:33 +0200	[thread overview]
Message-ID: <f6ca9fed0806272346y2e8fde2cwa27a79ee83d0c0af@mail.gmail.com> (raw)
In-Reply-To: <1214610613-6990-1-git-send-email-tomas.winkler@intel.com>

On Sat, Jun 28, 2008 at 1:50 AM, Tomas Winkler <tomas.winkler@intel.com> wrote:
> From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>
> This patch makes mac80211 refuse a WEP key whose length is not WEP40 nor
> WEP104.
>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  include/net/mac80211.h |    9 +++++++++
>  net/mac80211/wext.c    |    7 +++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index 02c79e6..6a6c4bc 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -557,6 +557,15 @@ enum ieee80211_key_alg {
>        ALG_CCMP,
>  };
>
> +/**
> + * enum ieee80211_key_len - key length
> + * @WEP40: WEP 5 byte long key
> + * @WEP104: WEP 13 byte long key
> + */
> +enum ieee80211_key_len {
> +       LEN_WEP40 = 5,
> +       LEN_WEP104 = 13,
> +};

What about 0 ?
See http://marc.info/?l=linux-wireless&m=121458316301507&w=2

  reply	other threads:[~2008-06-28  6:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-27 23:50 [PATCH 1/1] mac80211: don't accept WEP keys other than WEP40 and WEP104 Tomas Winkler
2008-06-28  6:46 ` drago01 [this message]
2008-06-28  7:57   ` Johannes Berg
2008-06-29  9:57     ` Tomas Winkler
2008-06-30  9:25       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6ca9fed0806272346y2e8fde2cwa27a79ee83d0c0af@mail.gmail.com \
    --to=drago01@gmail.com \
    --cc=emmanuel.grumbach@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox