From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com,
linux-wireless@vger.kernel.org, Guy Cohen <guy.cohen@intel.com>
Subject: Re: [PATCH 1/1] mac80211: move netif_carrier_on to after ieee80211_bss_info_change_notify
Date: Thu, 03 Jul 2008 19:07:50 +0200 [thread overview]
Message-ID: <1215104870.9975.17.camel@johannes.berg> (raw)
In-Reply-To: <1215104173-8918-1-git-send-email-tomas.winkler@intel.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
> - netif_carrier_on(dev);
> ifsta->flags |= IEEE80211_STA_PREV_BSSID_SET;
> memcpy(ifsta->prev_bssid, sdata->u.sta.bssid, ETH_ALEN);
> memcpy(wrqu.ap_addr.sa_data, sdata->u.sta.bssid, ETH_ALEN);
> ieee80211_sta_send_associnfo(dev, ifsta);
> } else {
> + netif_carrier_off(dev);
> ieee80211_sta_tear_down_BA_sessions(dev, ifsta->bssid);
> ifsta->flags &= ~IEEE80211_STA_ASSOCIATED;
> - netif_carrier_off(dev);
Maybe it should then be symmetric so that callers of the function have
to do it in both cases? Other than that, looks good.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-07-03 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 16:56 [PATCH 1/1] mac80211: move netif_carrier_on to after ieee80211_bss_info_change_notify Tomas Winkler
2008-07-03 17:07 ` Johannes Berg [this message]
2008-07-03 17:26 ` Tomas Winkler
2008-07-03 17:33 ` Johannes Berg
2008-07-03 17:45 ` Tomas Winkler
2008-07-03 17:57 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215104870.9975.17.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=guy.cohen@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).