Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: add direct probe before association
Date: Tue, 15 Jul 2008 10:37:45 +0200	[thread overview]
Message-ID: <1216111065.3535.3.camel@johannes.berg> (raw)
In-Reply-To: <1ba2fa240807150131w4a08ae6dhae7bab8ab6adbde7@mail.gmail.com> (sfid-20080715_103129_337219_1CFDD59C)

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

On Tue, 2008-07-15 at 11:31 +0300, Tomas Winkler wrote:
> On Tue, Jul 15, 2008 at 11:18 AM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> >
> >> +     ifsta->direct_probe_tries++;
> >> +     if (ifsta->direct_probe_tries > IEEE80211_AUTH_MAX_TRIES) {
> >> +             printk(KERN_DEBUG "%s: direct probe to AP %s timed out\n",
> >> +                    dev->name, print_mac(mac, ifsta->bssid));
> >> +             ifsta->state = IEEE80211_DISABLED;
> >> +             return;
> >> +     }
> >> +
> >> +     printk(KERN_DEBUG "%s: direct probe to AP %s try %d\n",
> >> +                     dev->name, print_mac(mac, ifsta->bssid),
> >> +                     ifsta->direct_probe_tries);
> >
> > I just removed all the log flooding. Don't add it back please.
> 
> Right, will resubmit.

Actually, it looks like I kept those for association because I decided
that we weren't printing them too much. It might be much nicer to send
them all as wireless events though, thoughts?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-07-15  8:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 23:07 [PATCH 1/1] mac80211: add direct probe before association Tomas Winkler
2008-07-15  8:18 ` Johannes Berg
2008-07-15  8:31   ` Tomas Winkler
2008-07-15  8:37     ` Johannes Berg [this message]
2008-07-16 13:11       ` Tomas Winkler
2008-07-16 13:20         ` Johannes Berg
2008-07-16 13:31           ` Tomas Winkler
2008-08-01 17:30 ` John W. Linville
2008-08-01 18:06   ` Johannes Berg
2008-08-01 19:25     ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216111065.3535.3.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox