From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: add direct probe before association
Date: Wed, 16 Jul 2008 16:11:24 +0300 [thread overview]
Message-ID: <1ba2fa240807160611h5d0d4ae5g68bfa2366cf514ec@mail.gmail.com> (raw)
In-Reply-To: <1216111065.3535.3.camel@johannes.berg>
On Tue, Jul 15, 2008 at 11:37 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Tue, 2008-07-15 at 11:31 +0300, Tomas Winkler wrote:
>> On Tue, Jul 15, 2008 at 11:18 AM, Johannes Berg
>> <johannes@sipsolutions.net> wrote:
>> >
>> >> + ifsta->direct_probe_tries++;
>> >> + if (ifsta->direct_probe_tries > IEEE80211_AUTH_MAX_TRIES) {
>> >> + printk(KERN_DEBUG "%s: direct probe to AP %s timed out\n",
>> >> + dev->name, print_mac(mac, ifsta->bssid));
>> >> + ifsta->state = IEEE80211_DISABLED;
>> >> + return;
>> >> + }
>> >> +
>> >> + printk(KERN_DEBUG "%s: direct probe to AP %s try %d\n",
>> >> + dev->name, print_mac(mac, ifsta->bssid),
>> >> + ifsta->direct_probe_tries);
>> >
>> > I just removed all the log flooding. Don't add it back please.
>>
>> Right, will resubmit.
>
> Actually, it looks like I kept those for association because I decided
> that we weren't printing them too much. It might be much nicer to send
> them all as wireless events though, thoughts?
Something like IWEVASSOCTIMEDOUT. Won't it make wpa_supplicant go nuts?
Thanks
Tomas
next prev parent reply other threads:[~2008-07-16 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 23:07 [PATCH 1/1] mac80211: add direct probe before association Tomas Winkler
2008-07-15 8:18 ` Johannes Berg
2008-07-15 8:31 ` Tomas Winkler
2008-07-15 8:37 ` Johannes Berg
2008-07-16 13:11 ` Tomas Winkler [this message]
2008-07-16 13:20 ` Johannes Berg
2008-07-16 13:31 ` Tomas Winkler
2008-08-01 17:30 ` John W. Linville
2008-08-01 18:06 ` Johannes Berg
2008-08-01 19:25 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240807160611h5d0d4ae5g68bfa2366cf514ec@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox