From: Johannes Berg <johannes@sipsolutions.net>
To: Chr <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
John W Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] p54: Fix regression due to commit b19fa1f
Date: Thu, 07 Aug 2008 17:26:36 +0200 [thread overview]
Message-ID: <1218122796.3630.4.camel@johannes.berg> (raw)
In-Reply-To: <200808071727.19129.chunkeey@web.de>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Thu, 2008-08-07 at 17:27 +0200, Chr wrote:
> On Thursday 07 August 2008 15:27:51 Johannes Berg wrote:
> > > + priv->tx_stats[le32_to_cpu(entry_data->frame_type - 4)].len--;
> >
> > Sorry for not catching this earlier, but this looks wrong, the -4 surely
> > should be outside the endian conversion?
>
> likely... let's do the job properly for once and for all.
> --
> + priv->tx_stats[entry_data->hw_queue - 4].len--;
> + u8 hw_queue;
Ah, heh, so it's not a u32 field after all?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-08-07 15:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 13:21 [PATCH] p54: Fix regression due to commit b19fa1f Larry Finger
2008-08-07 13:27 ` Johannes Berg
2008-08-07 15:20 ` Larry Finger
2008-08-07 15:27 ` Chr
2008-08-07 15:26 ` Johannes Berg [this message]
2008-08-07 15:27 ` Johannes Berg
2008-08-07 16:00 ` Chr
2008-08-07 16:34 ` Michael Buesch
2008-08-07 15:59 ` Larry Finger
2008-08-07 23:18 ` Chr
-- strict thread matches above, loose matches on Subject: below --
2008-08-04 21:14 Larry Finger
2008-08-06 22:57 ` Chr
2008-08-07 3:33 ` Larry Finger
2008-08-07 7:33 ` Chr
2008-08-07 6:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218122796.3630.4.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox