From: Larry Finger <Larry.Finger@lwfinger.net>
To: Chr <chunkeey@web.de>
Cc: linux-wireless@vger.kernel.org,
John W Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] p54: Fix regression due to commit b19fa1f
Date: Thu, 07 Aug 2008 10:59:26 -0500 [thread overview]
Message-ID: <489B1BDE.6070203@lwfinger.net> (raw)
In-Reply-To: <200808071727.19129.chunkeey@web.de>
Chr wrote:
> On Thursday 07 August 2008 15:27:51 Johannes Berg wrote:
>>> + priv->tx_stats[le32_to_cpu(entry_data->frame_type - 4)].len--;
>> Sorry for not catching this earlier, but this looks wrong, the -4 surely
>> should be outside the endian conversion?
>
> likely... let's do the job properly for once and for all.
> --
>
> This patch fixes not only the regression which has sneaked in
> with commit b19fa1f, but also provides some extra code for
> cts rates.
>
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
Is the extra code for cts rates a bug fix or a feature enhancement? If the
latter, then this patch should be in two parts. The main reason is that fixes
should go to stable as well as wireless-testing.
Larry
next prev parent reply other threads:[~2008-08-07 15:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 13:21 [PATCH] p54: Fix regression due to commit b19fa1f Larry Finger
2008-08-07 13:27 ` Johannes Berg
2008-08-07 15:20 ` Larry Finger
2008-08-07 15:27 ` Chr
2008-08-07 15:26 ` Johannes Berg
2008-08-07 15:27 ` Johannes Berg
2008-08-07 16:00 ` Chr
2008-08-07 16:34 ` Michael Buesch
2008-08-07 15:59 ` Larry Finger [this message]
2008-08-07 23:18 ` Chr
-- strict thread matches above, loose matches on Subject: below --
2008-08-04 21:14 Larry Finger
2008-08-06 22:57 ` Chr
2008-08-07 3:33 ` Larry Finger
2008-08-07 7:33 ` Chr
2008-08-07 6:35 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489B1BDE.6070203@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chunkeey@web.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox