Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: Reorder debugfs calls during netdev deinit
@ 2008-09-09 14:33 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2008-09-09 14:33 UTC (permalink / raw)
  To: John Linville; +Cc: Jouni Malinen, linux-wireless

From: Jouni Malinen <j@w1.fi>

ieee80211_free_keys() must be called before
ieee80211_debugfs_remove_netdev() in order to make sure that the
possible default_key symlink is removed before attempting to
remove the netdev debugfs directory.

Signed-off-by: Jouni Malinen <jouni.malinen@atheros.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
I've also seen the dangling netdev directories now, even without
802.11w.

 net/mac80211/iface.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- everything.orig/net/mac80211/iface.c	2008-09-09 15:09:55.000000000 +0200
+++ everything/net/mac80211/iface.c	2008-09-09 16:29:00.000000000 +0200
@@ -31,11 +31,11 @@ static void ieee80211_teardown_sdata(str
 	int flushed;
 	int i;
 
-	ieee80211_debugfs_remove_netdev(sdata);
-
 	/* free extra data */
 	ieee80211_free_keys(sdata);
 
+	ieee80211_debugfs_remove_netdev(sdata);
+
 	for (i = 0; i < IEEE80211_FRAGMENT_MAX; i++)
 		__skb_queue_purge(&sdata->fragments[i].skb_list);
 	sdata->fragment_next = 0;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-09-09 14:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-09 14:33 [PATCH] mac80211: Reorder debugfs calls during netdev deinit Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox