Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com,
	linux-wireless@vger.kernel.org,
	Ester Kummer <ester.kummer@intel.com>,
	Luis Carlos Cobo <luisca@cozybit.com>
Subject: Re: [PATCH 1/1] mac80211: scan on IBSS mode like on STA mode
Date: Wed, 10 Sep 2008 23:37:09 +0200	[thread overview]
Message-ID: <1221082630.3804.43.camel@johannes.berg> (raw)
In-Reply-To: <1ba2fa240809101432u23bf198bqcf9bd0e9f91a2ae8@mail.gmail.com> (sfid-20080910_233253_312411_FCC1C92C)

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On Thu, 2008-09-11 at 00:32 +0300, Tomas Winkler wrote:

> Okay so here is the scenario. Iwlwifi reject scan that is triggered
> withing fixed period after
> association to leave time to finish EAPOL exchange.

Why is iwlwifi thinking it's associating in an IBSS?

> We never hit the problem in STA mode because of this code
> 
>  if (sdata->vif.type != IEEE80211_IF_TYPE_STA)
> 		return ieee80211_sta_start_scan(dev, ssid, ssid_len);
> 
> which makes it go through the work queue, just pure timing luck.

Well the remainder of the code makes it go through, but yeah.

> I will remove this delay for IBSS, there is no association and no 1X
> is going on.

Ok, makes sense.

> For BSS I suggest to enforce similar delay already mac80211, iwlwifi I
> just return empty scan completion and buffered results will be
> returned.

We might want to enforce a similar delay like that in mac80211 instead
of iwlwifi, yeah.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-09-10 21:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-08 13:31 [PATCH 1/1] mac80211: scan on IBSS mode like on STA mode Tomas Winkler
2008-09-08 14:55 ` Johannes Berg
2008-09-08 15:05   ` Johannes Berg
2008-09-08 15:16     ` Johannes Berg
2008-09-08 16:53       ` Tomas Winkler
2008-09-08 18:13         ` Johannes Berg
2008-09-08 22:24           ` Tomas Winkler
2008-09-10 21:32             ` Tomas Winkler
2008-09-10 21:37               ` Johannes Berg [this message]
2008-09-08 16:42   ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221082630.3804.43.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=ester.kummer@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=luisca@cozybit.com \
    --cc=tomasw@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox