From: "Tomas Winkler" <tomasw@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, yi.zhu@intel.com,
linux-wireless@vger.kernel.org,
"Ester Kummer" <ester.kummer@intel.com>,
"Luis Carlos Cobo" <luisca@cozybit.com>
Subject: Re: [PATCH 1/1] mac80211: scan on IBSS mode like on STA mode
Date: Mon, 8 Sep 2008 19:53:02 +0300 [thread overview]
Message-ID: <1ba2fa240809080953mfe2ab86l5417679e4cb29df1@mail.gmail.com> (raw)
In-Reply-To: <1220887018.31304.74.camel@johannes.berg>
On Mon, Sep 8, 2008 at 6:16 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Mon, 2008-09-08 at 17:05 +0200, Johannes Berg wrote:
>
>> > Can you explain why? Or can anybody else explain why we do this
>> > difference at all? And how should mesh behave?
>>
>> Actually, I do understand the difference now (explanation added below)
>> and if I'm guessing the problem you're having correctly your patch is
>> wrong. I think you want something like the patch below (never mind the
>> fact that it's against scan.c, I'm shuffling code)
>
>> if (local->sta_sw_scanning || local->sta_hw_scanning) {
>> if (local->scan_sdata == sdata)
>> return 0;
>> return -EBUSY;
>> }
>
> Then again, ieee80211_sta_start_scan does that check as well, so now I'm
> confused.
The bug is that scan can be triggered in STA and IBSS internally. If
you request scan from the application (iwlist) while
internally scan is running application won't fetch scan results
because the -EBUSY is returned on scan request.
Tomas
>
next prev parent reply other threads:[~2008-09-08 16:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-08 13:31 [PATCH 1/1] mac80211: scan on IBSS mode like on STA mode Tomas Winkler
2008-09-08 14:55 ` Johannes Berg
2008-09-08 15:05 ` Johannes Berg
2008-09-08 15:16 ` Johannes Berg
2008-09-08 16:53 ` Tomas Winkler [this message]
2008-09-08 18:13 ` Johannes Berg
2008-09-08 22:24 ` Tomas Winkler
2008-09-10 21:32 ` Tomas Winkler
2008-09-10 21:37 ` Johannes Berg
2008-09-08 16:42 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ba2fa240809080953mfe2ab86l5417679e4cb29df1@mail.gmail.com \
--to=tomasw@gmail.com \
--cc=ester.kummer@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luisca@cozybit.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox