Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
Date: Tue, 14 Oct 2008 12:36:53 -0400	[thread overview]
Message-ID: <1224002213.1799.2.camel@localhost.localdomain> (raw)
In-Reply-To: <ea11fea30810130352i3cea0579g9950289254c8e628@mail.gmail.com>

On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
> Below patch removes the following warning during compilation.
> 
> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
> 
> 
> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>

Acked-by: Dan Williams <dcbw@redhat.com>

> ---
>  drivers/net/wireless/libertas/cmd.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/libertas/cmd.c
> b/drivers/net/wireless/libertas/cmd.c
> index a912fb6..297696d 100644
> --- a/drivers/net/wireless/libertas/cmd.c
> +++ b/drivers/net/wireless/libertas/cmd.c
> @@ -823,7 +823,9 @@ int lbs_update_channel(struct lbs_private *priv)
>  int lbs_set_channel(struct lbs_private *priv, u8 channel)
>  {
>  	struct cmd_ds_802_11_rf_channel cmd;
> +#ifdef DEBUG
>  	u8 old_channel = priv->curbssparams.channel;
> +#endif
>  	int ret = 0;
> 
>  	lbs_deb_enter(LBS_DEB_CMD);


  parent reply	other threads:[~2008-10-14 16:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13 10:52 [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c Manish Katiyar
2008-10-14 16:00 ` Manish Katiyar
2008-10-14 16:36 ` Dan Williams [this message]
2008-10-15  8:10   ` Manish Katiyar
2008-10-15  8:47     ` Johannes Berg
2008-10-15  9:01       ` Manish Katiyar
2008-10-15 13:20         ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224002213.1799.2.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox