* [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
@ 2008-10-13 10:52 Manish Katiyar
2008-10-14 16:00 ` Manish Katiyar
2008-10-14 16:36 ` Dan Williams
0 siblings, 2 replies; 7+ messages in thread
From: Manish Katiyar @ 2008-10-13 10:52 UTC (permalink / raw)
To: dcbw, libertas-dev, linux-wireless; +Cc: mkatiyar
Below patch removes the following warning during compilation.
drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
---
drivers/net/wireless/libertas/cmd.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/libertas/cmd.c
b/drivers/net/wireless/libertas/cmd.c
index a912fb6..297696d 100644
--- a/drivers/net/wireless/libertas/cmd.c
+++ b/drivers/net/wireless/libertas/cmd.c
@@ -823,7 +823,9 @@ int lbs_update_channel(struct lbs_private *priv)
int lbs_set_channel(struct lbs_private *priv, u8 channel)
{
struct cmd_ds_802_11_rf_channel cmd;
+#ifdef DEBUG
u8 old_channel = priv->curbssparams.channel;
+#endif
int ret = 0;
lbs_deb_enter(LBS_DEB_CMD);
--
1.5.4.3
Thanks -
Manish
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-13 10:52 [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c Manish Katiyar
@ 2008-10-14 16:00 ` Manish Katiyar
2008-10-14 16:36 ` Dan Williams
1 sibling, 0 replies; 7+ messages in thread
From: Manish Katiyar @ 2008-10-14 16:00 UTC (permalink / raw)
To: dcbw, libertas-dev, linux-wireless; +Cc: mkatiyar
On Mon, Oct 13, 2008 at 4:22 PM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Below patch removes the following warning during compilation.
>
> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
Any ack/nack on this ??
Thanks -
Manish
>
>
> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
> ---
> drivers/net/wireless/libertas/cmd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/cmd.c
> b/drivers/net/wireless/libertas/cmd.c
> index a912fb6..297696d 100644
> --- a/drivers/net/wireless/libertas/cmd.c
> +++ b/drivers/net/wireless/libertas/cmd.c
> @@ -823,7 +823,9 @@ int lbs_update_channel(struct lbs_private *priv)
> int lbs_set_channel(struct lbs_private *priv, u8 channel)
> {
> struct cmd_ds_802_11_rf_channel cmd;
> +#ifdef DEBUG
> u8 old_channel = priv->curbssparams.channel;
> +#endif
> int ret = 0;
>
> lbs_deb_enter(LBS_DEB_CMD);
> --
> 1.5.4.3
>
>
> Thanks -
> Manish
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-13 10:52 [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c Manish Katiyar
2008-10-14 16:00 ` Manish Katiyar
@ 2008-10-14 16:36 ` Dan Williams
2008-10-15 8:10 ` Manish Katiyar
1 sibling, 1 reply; 7+ messages in thread
From: Dan Williams @ 2008-10-14 16:36 UTC (permalink / raw)
To: Manish Katiyar; +Cc: libertas-dev, linux-wireless
On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
> Below patch removes the following warning during compilation.
>
> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
>
>
> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/wireless/libertas/cmd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/cmd.c
> b/drivers/net/wireless/libertas/cmd.c
> index a912fb6..297696d 100644
> --- a/drivers/net/wireless/libertas/cmd.c
> +++ b/drivers/net/wireless/libertas/cmd.c
> @@ -823,7 +823,9 @@ int lbs_update_channel(struct lbs_private *priv)
> int lbs_set_channel(struct lbs_private *priv, u8 channel)
> {
> struct cmd_ds_802_11_rf_channel cmd;
> +#ifdef DEBUG
> u8 old_channel = priv->curbssparams.channel;
> +#endif
> int ret = 0;
>
> lbs_deb_enter(LBS_DEB_CMD);
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-14 16:36 ` Dan Williams
@ 2008-10-15 8:10 ` Manish Katiyar
2008-10-15 8:47 ` Johannes Berg
0 siblings, 1 reply; 7+ messages in thread
From: Manish Katiyar @ 2008-10-15 8:10 UTC (permalink / raw)
To: Dan Williams; +Cc: libertas-dev, linux-wireless
On Tue, Oct 14, 2008 at 10:06 PM, Dan Williams <dcbw@redhat.com> wrote:
> On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
>> Below patch removes the following warning during compilation.
>>
>> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
>>
>>
>> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
>
> Acked-by: Dan Williams <dcbw@redhat.com>
Hi Dan,
A newbie question. Will you merge this patch or will I have to send it
to Andrew again acked by you ?
Thanks -
Manish
>
>> ---
>> drivers/net/wireless/libertas/cmd.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/libertas/cmd.c
>> b/drivers/net/wireless/libertas/cmd.c
>> index a912fb6..297696d 100644
>> --- a/drivers/net/wireless/libertas/cmd.c
>> +++ b/drivers/net/wireless/libertas/cmd.c
>> @@ -823,7 +823,9 @@ int lbs_update_channel(struct lbs_private *priv)
>> int lbs_set_channel(struct lbs_private *priv, u8 channel)
>> {
>> struct cmd_ds_802_11_rf_channel cmd;
>> +#ifdef DEBUG
>> u8 old_channel = priv->curbssparams.channel;
>> +#endif
>> int ret = 0;
>>
>> lbs_deb_enter(LBS_DEB_CMD);
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-15 8:10 ` Manish Katiyar
@ 2008-10-15 8:47 ` Johannes Berg
2008-10-15 9:01 ` Manish Katiyar
0 siblings, 1 reply; 7+ messages in thread
From: Johannes Berg @ 2008-10-15 8:47 UTC (permalink / raw)
To: Manish Katiyar; +Cc: Dan Williams, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
[dropping libertas list, subscribers only]
On Wed, 2008-10-15 at 13:40 +0530, Manish Katiyar wrote:
> On Tue, Oct 14, 2008 at 10:06 PM, Dan Williams <dcbw@redhat.com> wrote:
> > On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
> >> Below patch removes the following warning during compilation.
> >>
> >> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
> >>
> >>
> >> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
> >
> > Acked-by: Dan Williams <dcbw@redhat.com>
>
> Hi Dan,
>
> A newbie question. Will you merge this patch or will I have to send it
> to Andrew again acked by you ?
John has already applied it, Andrew isn't typically involved with
wireless.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-15 8:47 ` Johannes Berg
@ 2008-10-15 9:01 ` Manish Katiyar
2008-10-15 13:20 ` John W. Linville
0 siblings, 1 reply; 7+ messages in thread
From: Manish Katiyar @ 2008-10-15 9:01 UTC (permalink / raw)
To: Johannes Berg; +Cc: Dan Williams, linux-wireless
On Wed, Oct 15, 2008 at 2:17 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> [dropping libertas list, subscribers only]
>
> On Wed, 2008-10-15 at 13:40 +0530, Manish Katiyar wrote:
>> On Tue, Oct 14, 2008 at 10:06 PM, Dan Williams <dcbw@redhat.com> wrote:
>> > On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
>> >> Below patch removes the following warning during compilation.
>> >>
>> >> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
>> >>
>> >>
>> >> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
>> >
>> > Acked-by: Dan Williams <dcbw@redhat.com>
>>
>> Hi Dan,
>>
>> A newbie question. Will you merge this patch or will I have to send it
>> to Andrew again acked by you ?
>
> John has already applied it, Andrew isn't typically involved with
> wireless.
Thanks a lot John.
>
> johannes
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c
2008-10-15 9:01 ` Manish Katiyar
@ 2008-10-15 13:20 ` John W. Linville
0 siblings, 0 replies; 7+ messages in thread
From: John W. Linville @ 2008-10-15 13:20 UTC (permalink / raw)
To: Manish Katiyar; +Cc: Johannes Berg, Dan Williams, linux-wireless
On Wed, Oct 15, 2008 at 02:31:37PM +0530, Manish Katiyar wrote:
> On Wed, Oct 15, 2008 at 2:17 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > [dropping libertas list, subscribers only]
> >
> > On Wed, 2008-10-15 at 13:40 +0530, Manish Katiyar wrote:
> >> On Tue, Oct 14, 2008 at 10:06 PM, Dan Williams <dcbw@redhat.com> wrote:
> >> > On Mon, 2008-10-13 at 16:22 +0530, Manish Katiyar wrote:
> >> >> Below patch removes the following warning during compilation.
> >> >>
> >> >> drivers/net/wireless/libertas/cmd.c:826: warning: unused variable 'old_channel'
> >> >>
> >> >>
> >> >> Signed-off-by : Manish Katiyar <mkatiyar@gmail.com>
> >> >
> >> > Acked-by: Dan Williams <dcbw@redhat.com>
> >>
> >> Hi Dan,
> >>
> >> A newbie question. Will you merge this patch or will I have to send it
> >> to Andrew again acked by you ?
> >
> > John has already applied it, Andrew isn't typically involved with
> > wireless.
>
> Thanks a lot John.
No, thank you! :-)
--
John W. Linville Linux should be at the core
linville@tuxdriver.com of your literate lifestyle.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-10-15 13:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-13 10:52 [PATCH] libertas : Remove unused variable warning "old_channel" from drivers/net/wireless/libertas/cmd.c Manish Katiyar
2008-10-14 16:00 ` Manish Katiyar
2008-10-14 16:36 ` Dan Williams
2008-10-15 8:10 ` Manish Katiyar
2008-10-15 8:47 ` Johannes Berg
2008-10-15 9:01 ` Manish Katiyar
2008-10-15 13:20 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox