From: Johannes Berg <johannes@sipsolutions.net>
To: Rami Rosen <ramirose@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH ] mac80211: check return value of dev_alloc_skb() in ieee80211_sta_join_ibss().
Date: Wed, 22 Oct 2008 09:45:17 +0200 [thread overview]
Message-ID: <1224661517.28639.29.camel@johannes.berg> (raw)
In-Reply-To: <eb3ff54b0810220042y43ea248qba1064a3eedf85b1@mail.gmail.com> (sfid-20081022_094238_975856_C75CB966)
[-- Attachment #1: Type: text/plain, Size: 306 bytes --]
On Wed, 2008-10-22 at 09:42 +0200, Rami Rosen wrote:
> Hello,
>
> Do we want to continue as usual if dev_alloc_skb() in theis method fails?
well if anything then we shouldn't do half the stuff and then abort, so
the allocation/check should be moved to the beginning of the function...
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-10-22 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 7:00 [PATCH ] mac80211: check return value of dev_alloc_skb() in ieee80211_sta_join_ibss() Rami Rosen
2008-10-22 7:36 ` Johannes Berg
2008-10-22 7:42 ` Rami Rosen
2008-10-22 7:45 ` Johannes Berg [this message]
2008-10-22 8:11 ` Jouni Malinen
2008-10-22 8:17 ` Johannes Berg
2008-10-22 18:55 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224661517.28639.29.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox