From: Jouni Malinen <j@w1.fi>
To: Rami Rosen <ramirose@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH ] mac80211: check return value of dev_alloc_skb() in ieee80211_sta_join_ibss().
Date: Wed, 22 Oct 2008 11:11:49 +0300 [thread overview]
Message-ID: <20081022081149.GE16005@jm.kir.nu> (raw)
In-Reply-To: <eb3ff54b0810220042y43ea248qba1064a3eedf85b1@mail.gmail.com>
On Wed, Oct 22, 2008 at 09:42:37AM +0200, Rami Rosen wrote:
> Do we want to continue as usual if dev_alloc_skb() in theis method fails?
I think we should continue and as such, I would rather not see the patch
that proposes to abort here go in. The allocated skb is not used at this
point anyway; it is only used as an optimization to prepare a ProbeRsp
frame for possible future use. This could be done at the time when
ProbeReq is received (and we sent the last Beacon), i.e., only when
needed. Or if the optimization of generating this only once is
considered desirable, that place could try to allocate a new skb if the
one here failed (or do it on first need and cache the result).
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2008-10-22 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 7:00 [PATCH ] mac80211: check return value of dev_alloc_skb() in ieee80211_sta_join_ibss() Rami Rosen
2008-10-22 7:36 ` Johannes Berg
2008-10-22 7:42 ` Rami Rosen
2008-10-22 7:45 ` Johannes Berg
2008-10-22 8:11 ` Jouni Malinen [this message]
2008-10-22 8:17 ` Johannes Berg
2008-10-22 18:55 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022081149.GE16005@jm.kir.nu \
--to=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ramirose@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox