* [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE
@ 2008-10-23 6:44 Sujith
2008-10-23 6:52 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Sujith @ 2008-10-23 6:44 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Jouni.Malinen, Luis.Rodriguez, johannes
A warning would be printed for every packet that
is transmitted if the rate control information isn't
setup. Change this to WARN_ON_ONCE.
Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
---
net/mac80211/tx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 8b56048..3678325 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -565,8 +565,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
IEEE80211_TX_RC_USE_RTS_CTS;
/* RC is busted */
- if (WARN_ON(info->control.rates[i].idx >=
- sband->n_bitrates)) {
+ if (WARN_ON_ONCE(info->control.rates[i].idx >=
+ sband->n_bitrates)) {
info->control.rates[i].idx = -1;
continue;
}
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE
2008-10-23 6:44 [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE Sujith
@ 2008-10-23 6:52 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-10-23 6:52 UTC (permalink / raw)
To: Sujith; +Cc: linville, linux-wireless, Jouni.Malinen, Luis.Rodriguez
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On Thu, 2008-10-23 at 12:14 +0530, Sujith wrote:
> A warning would be printed for every packet that
> is transmitted if the rate control information isn't
> setup. Change this to WARN_ON_ONCE.
> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
but please do set up the rate control information to fix the
fragmentation issue etc. :)
> ---
> net/mac80211/tx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 8b56048..3678325 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -565,8 +565,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
> IEEE80211_TX_RC_USE_RTS_CTS;
>
> /* RC is busted */
> - if (WARN_ON(info->control.rates[i].idx >=
> - sband->n_bitrates)) {
> + if (WARN_ON_ONCE(info->control.rates[i].idx >=
> + sband->n_bitrates)) {
> info->control.rates[i].idx = -1;
> continue;
> }
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-23 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-23 6:44 [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE Sujith
2008-10-23 6:52 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox