Linux wireless drivers development
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@linux.intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
	ipw3945-devel@lists.sourceforge.net,
	Fabrice Bellet <fabrice@bellet.info>,
	Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH 09/10] iwl3945: iwl3945_mac_get_tsf() should not return zero
Date: Thu, 23 Oct 2008 23:48:57 -0700	[thread overview]
Message-ID: <1224830938-1577-10-git-send-email-reinette.chatre@linux.intel.com> (raw)
In-Reply-To: <1224830938-1577-9-git-send-email-reinette.chatre@linux.intel.com>

From: Fabrice Bellet <fabrice@bellet.info>

The problem fixed here is that iwl3945_mac_get_tsf() returns 0, as the
function is not implemented, and this is considered as a valid value by
the mac layer in mlme.c:1605. The consequence is that the STA in ad-hoc
mode is inserted/removed quite frequently due to IBSS merging.

This patch fixes :
http://www.intellinuxwireless.org/bugzilla/show_bug.cgi?id=1781
and https://bugzilla.redhat.com/show_bug.cgi?id=459401

Signed-off-by: Fabrice Bellet <fabrice@bellet.info>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
 drivers/net/wireless/iwlwifi/iwl3945-base.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 2870b61..813662f 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -7209,14 +7209,6 @@ static int iwl3945_mac_get_stats(struct ieee80211_hw *hw,
 	return 0;
 }
 
-static u64 iwl3945_mac_get_tsf(struct ieee80211_hw *hw)
-{
-	IWL_DEBUG_MAC80211("enter\n");
-	IWL_DEBUG_MAC80211("leave\n");
-
-	return 0;
-}
-
 static void iwl3945_mac_reset_tsf(struct ieee80211_hw *hw)
 {
 	struct iwl3945_priv *priv = hw->priv;
@@ -7859,7 +7851,6 @@ static struct ieee80211_ops iwl3945_hw_ops = {
 	.get_stats = iwl3945_mac_get_stats,
 	.get_tx_stats = iwl3945_mac_get_tx_stats,
 	.conf_tx = iwl3945_mac_conf_tx,
-	.get_tsf = iwl3945_mac_get_tsf,
 	.reset_tsf = iwl3945_mac_reset_tsf,
 	.bss_info_changed = iwl3945_bss_info_changed,
 	.hw_scan = iwl3945_mac_hw_scan
-- 
1.5.4.3


  reply	other threads:[~2008-10-24  6:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24  6:48 [PATCH 0/10] iwlwifi driver updates Reinette Chatre
2008-10-24  6:48 ` [PATCH 01/10] iwlwifi: refactor TX response flow Reinette Chatre
2008-10-24  6:48   ` [PATCH 02/10] iwlwifi: don't update TFD free counter for invalid station Reinette Chatre
2008-10-24  6:48     ` [PATCH 03/10] iwlwifi: parametrize eeprom versions Reinette Chatre
2008-10-24  6:48       ` [PATCH 04/10] iwlwifi: calibration command namespace renaming Reinette Chatre
2008-10-24  6:48         ` [PATCH 05/10] iwlwifi: convert correctly rate_n_flags to PLCP index for mimo3 packets Reinette Chatre
2008-10-24  6:48           ` [PATCH 06/10] iwlwifi: clear scanning bits upon failure Reinette Chatre
2008-10-24  6:48             ` [PATCH 07/10] iwlwifi: refactor tx byte count table usage Reinette Chatre
2008-10-24  6:48               ` [PATCH 08/10] iwlwifi: run through spell checker Reinette Chatre
2008-10-24  6:48                 ` Reinette Chatre [this message]
2008-10-24  6:48                   ` [PATCH 10/10] iwlwifi: Update reclaim flag Reinette Chatre
2008-10-24  8:27               ` [PATCH 07/10] iwlwifi: refactor tx byte count table usage Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224830938-1577-10-git-send-email-reinette.chatre@linux.intel.com \
    --to=reinette.chatre@linux.intel.com \
    --cc=fabrice@bellet.info \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox