From: Reinette Chatre <reinette.chatre@linux.intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Mohamed Abbas <mohamed.abbas@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH 06/10] iwlwifi: clear scanning bits upon failure
Date: Thu, 23 Oct 2008 23:48:54 -0700 [thread overview]
Message-ID: <1224830938-1577-7-git-send-email-reinette.chatre@linux.intel.com> (raw)
In-Reply-To: <1224830938-1577-6-git-send-email-reinette.chatre@linux.intel.com>
From: Mohamed Abbas <mohamed.abbas@intel.com>
In iwl_bg_request_scan function, if we could not send a
scan command it will go to done.
In done it does the right thing to call mac80211 with
scan complete, but the problem is STATUS_SCAN_HW is still
set causing any future scan to fail. Fix by clearing the scanning status
bits if scan fails.
Signed-off-by: Mohamed Abbas <mohamed.abbas@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-scan.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-scan.c b/drivers/net/wireless/iwlwifi/iwl-scan.c
index 86b7457..8e262d9 100644
--- a/drivers/net/wireless/iwlwifi/iwl-scan.c
+++ b/drivers/net/wireless/iwlwifi/iwl-scan.c
@@ -873,6 +873,13 @@ static void iwl_bg_request_scan(struct work_struct *data)
return;
done:
+ /* Cannot perform scan. Make sure we clear scanning
+ * bits from status so next scan request can be performed.
+ * If we don't clear scanning status bit here all next scan
+ * will fail
+ */
+ clear_bit(STATUS_SCAN_HW, &priv->status);
+ clear_bit(STATUS_SCANNING, &priv->status);
/* inform mac80211 scan aborted */
queue_work(priv->workqueue, &priv->scan_completed);
mutex_unlock(&priv->mutex);
--
1.5.4.3
next prev parent reply other threads:[~2008-10-24 6:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 6:48 [PATCH 0/10] iwlwifi driver updates Reinette Chatre
2008-10-24 6:48 ` [PATCH 01/10] iwlwifi: refactor TX response flow Reinette Chatre
2008-10-24 6:48 ` [PATCH 02/10] iwlwifi: don't update TFD free counter for invalid station Reinette Chatre
2008-10-24 6:48 ` [PATCH 03/10] iwlwifi: parametrize eeprom versions Reinette Chatre
2008-10-24 6:48 ` [PATCH 04/10] iwlwifi: calibration command namespace renaming Reinette Chatre
2008-10-24 6:48 ` [PATCH 05/10] iwlwifi: convert correctly rate_n_flags to PLCP index for mimo3 packets Reinette Chatre
2008-10-24 6:48 ` Reinette Chatre [this message]
2008-10-24 6:48 ` [PATCH 07/10] iwlwifi: refactor tx byte count table usage Reinette Chatre
2008-10-24 6:48 ` [PATCH 08/10] iwlwifi: run through spell checker Reinette Chatre
2008-10-24 6:48 ` [PATCH 09/10] iwl3945: iwl3945_mac_get_tsf() should not return zero Reinette Chatre
2008-10-24 6:48 ` [PATCH 10/10] iwlwifi: Update reclaim flag Reinette Chatre
2008-10-24 8:27 ` [PATCH 07/10] iwlwifi: refactor tx byte count table usage Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1224830938-1577-7-git-send-email-reinette.chatre@linux.intel.com \
--to=reinette.chatre@linux.intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mohamed.abbas@intel.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox