* [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info
[not found] <Pine.LNX.4.64.0811120854290.13217@anakin>
@ 2008-11-12 15:05 ` John W. Linville
2008-11-12 17:08 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: John W. Linville @ 2008-11-12 15:05 UTC (permalink / raw)
To: linux-wireless
Cc: linux-kernel, linux-next, Stephen Rothwell, Geert Uytterhoeven,
Johannes Berg, John W. Linville
Otherwise, the BUILD_BUG_ON calls in ieee80211_tx_info_clear_status can
fail on some architectures.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
Why do we have those BUILD_BUG_ON calls anyway? Hmmm...
include/net/mac80211.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index feb52cc..38302d6 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -333,6 +333,7 @@ struct ieee80211_tx_info {
u8 antenna_sel_tx;
/* 2 byte hole */
+ u8 pad[2];
union {
struct {
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info
2008-11-12 15:05 ` [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info John W. Linville
@ 2008-11-12 17:08 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-11-12 17:08 UTC (permalink / raw)
To: John W. Linville
Cc: linux-wireless, linux-kernel, linux-next, Stephen Rothwell,
Geert Uytterhoeven
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Wed, 2008-11-12 at 10:05 -0500, John W. Linville wrote:
> Otherwise, the BUILD_BUG_ON calls in ieee80211_tx_info_clear_status can
> fail on some architectures.
>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
> Why do we have those BUILD_BUG_ON calls anyway? Hmmm...
Because we actually use those offsets in places to clear things.
> include/net/mac80211.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index feb52cc..38302d6 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -333,6 +333,7 @@ struct ieee80211_tx_info {
> u8 antenna_sel_tx;
>
> /* 2 byte hole */
> + u8 pad[2];
>
> union {
> struct {
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-12 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.64.0811120854290.13217@anakin>
2008-11-12 15:05 ` [PATCH] mac80211: add explicit padding in struct ieee80211_tx_info John W. Linville
2008-11-12 17:08 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).