Re: [PATCH 2/2] zd1211rw: enable an AP that can't support fully PS clients (wireless-testing).

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Mon, 2008-11-24 at 13:38 +0200, Rami Rosen wrote:
> Hello,
>   I indeed intend to fix the driver to do the buffering and use
> _get_buffered_bc() (and also add sequence numbering, which is easier).
> It will take time to fix it and to test it with hostapd and clients.
> 
> When it will be ready, the only thing which will be needed is
> to remove the "hw->wiphy->ap_ps_challenged = true" from
> zd_mac_alloc_hw() in zd_mac.c. The other changes in the driver should
> of course stay (adding handling of NL80211_IFTYPE_AP).
> 
> As far as I understand, the zd1211rw is not the only one which does
> not support buffering; (and I assume there will be other such drivers
> without this support in the future); so it seems to me that the
> nl80211 patch, which enable users who would prefer to have an AP that
> can't support fully PS clients, rather than not having an AP at all,
> is a good enough reason for the nl80211 patch.
> 
> Using Linux as an access point with a standard and a wide range of
> commodity wireless drivers seems really a nice and important feature.

Well, I'd rather have the nl80211/cfg80211 part only when we find out
that it's absolutely necessary. I don't see a problem in waiting now
until you either figure out how to fix zd1211 or determine that it's not
possible at all.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]