Re: [PATCH 2/2] zd1211rw: enable an AP that can't support fully PS clients (wireless-testing).

["Rami Rosen" <ramirose@gmail.com>]

Hello,
If you are talking about whether the zd1211 driver can buffer
mcast/bcast frames in software, it seems to me that the answer is
negative, since there is no call for ieee80211_get_buffered_bc() in
the zd1211rw driver code and also there is no handling of
IEEE80211_TX_CTL_SEND_AFTER_DTIM or
IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING in the zd1211rw driver code.
This what made me add the NL80211_ATTR_WIPHY_AP_PS_CHALLENGED
attribute and prepare this patch.


Regards,
Rami Rosen



On Mon, Nov 24, 2008 at 12:35 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2008-11-24 at 09:44 +0200, Rami Rosen wrote:
>> This patch enables master mode support in zd1211rw driver and enables
>> it to support the PS challenged mode when used in master mode.
>>
>> It adds this functionality in the zd1211rw driver by adding support to
>> master mode (NL80211_IFTYPE_AP) in zd_op_add_interface() and in
>> zd_mac_alloc_hw() methods
>> of drivers/net/wireless/zd_mac.c.
>>
>> In addition, the new boolean member of wiphy struct, ap_ps_challenged,
>> is initialized to true in zd_mac_alloc_hw().
>
> This is all fine, but I'm starting to wonder why we're doing this at
> all. Have we actually determined that zd1211 cannot buffer mcast/bcast
> frames at all? Might it be worth asking around in Zydas/Atheros?
>
> johannes
>