From: Johannes Berg <johannes@sipsolutions.net>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: "Stefanik Gábor" <netrolller.3d@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Hin-Tak Leung" <hintak.leung@gmail.com>,
"Larry Finger" <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
"Felix Fietkau" <nbd@openwrt.org>
Subject: Re: [RFC] rtl8187: Do not wait for an ACK when IEEE80211_TX_CTL_NO_ACK is set
Date: Thu, 27 Nov 2008 22:59:09 +0100 [thread overview]
Message-ID: <1227823149.7559.1.camel@johannes.berg> (raw)
In-Reply-To: <200811271952.21408.herton@mandriva.com.br>
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
On Thu, 2008-11-27 at 19:52 -0200, Herton Ronaldo Krzesinski wrote:
> In this case then shouldn't mac80211/rate control alg give a right rates[0].count?
It probably should put 1 into that value, yes. It doesn't seem to
enforce that now though, I'll take a look at doing that.
> And other drivers have same bug?
possibly.
Another thing: the ".count" is the number of tries you should do, so if
the hardware expects retries then you need to subtract 1.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-11-27 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 22:31 [RFC] rtl8187: Do not wait for an ACK when IEEE80211_TX_CTL_NO_ACK is set Stefanik Gábor
2008-11-27 17:43 ` Herton Ronaldo Krzesinski
2008-11-27 20:02 ` Stefanik Gábor
2008-11-27 21:52 ` Herton Ronaldo Krzesinski
2008-11-27 21:59 ` Johannes Berg [this message]
2008-11-27 22:39 ` Stefanik Gábor
2008-11-28 0:33 ` herton
2008-11-27 23:10 ` Hin-Tak Leung
2008-11-27 23:45 ` Hin-Tak Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227823149.7559.1.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=herton@mandriva.com.br \
--cc=hintak.leung@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=netrolller.3d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox