Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Stefanik Gábor" <netrolller.3d@gmail.com>
To: "Herton Ronaldo Krzesinski" <herton@mandriva.com.br>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"Hin-Tak Leung" <hintak.leung@gmail.com>,
	"Larry Finger" <Larry.Finger@lwfinger.net>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [RFC] rtl8187: Do not wait for an ACK when IEEE80211_TX_CTL_NO_ACK is set
Date: Thu, 27 Nov 2008 21:02:22 +0100	[thread overview]
Message-ID: <69e28c910811271202s295bbf5bo3dc8c04c50b08a01@mail.gmail.com> (raw)
In-Reply-To: <200811271543.59126.herton@mandriva.com.br>

On Thu, Nov 27, 2008 at 6:43 PM, Herton Ronaldo Krzesinski
<herton@mandriva.com.br> wrote:
>
> nack.
>
> I've seen other drivers set just a flag when hardware has a bit field to
> signalize that there isn't need to ack the tx packet to be sent, but
> don't saw anyone changing retry in tx hw header. Also setting to 0 in
> no_ack case looks wrong, for example see ath5k where it even checks for
> 0 and returns an error if you try to do this.
>
> --
> []'s
> Herton
>

IMO the current implementation is even worse - completely disregard
NO_ACK, and when a packet that should not be ACKed according to IEEE
802.11:2007 is sent (such as a broadcast), retry repeatedly until
timeout.
Also, v26.1010 of the vendor driver does exactly what my patch does.

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

  reply	other threads:[~2008-11-27 20:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26 22:31 [RFC] rtl8187: Do not wait for an ACK when IEEE80211_TX_CTL_NO_ACK is set Stefanik Gábor
2008-11-27 17:43 ` Herton Ronaldo Krzesinski
2008-11-27 20:02   ` Stefanik Gábor [this message]
2008-11-27 21:52     ` Herton Ronaldo Krzesinski
2008-11-27 21:59       ` Johannes Berg
2008-11-27 22:39         ` Stefanik Gábor
2008-11-28  0:33           ` herton
2008-11-27 23:10       ` Hin-Tak Leung
2008-11-27 23:45 ` Hin-Tak Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69e28c910811271202s295bbf5bo3dc8c04c50b08a01@mail.gmail.com \
    --to=netrolller.3d@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=herton@mandriva.com.br \
    --cc=hintak.leung@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox