Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] cfg80211: fix wiphy remove if no regulatory request
@ 2008-12-01 11:07 Johannes Berg
  2008-12-01 19:01 ` Luis R. Rodriguez
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2008-12-01 11:07 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

Fixes the segfault I just pointed out.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/wireless/reg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- everything.orig/net/wireless/reg.c	2008-12-01 11:59:18.000000000 +0100
+++ everything/net/wireless/reg.c	2008-12-01 11:59:30.000000000 +0100
@@ -1330,7 +1330,7 @@ int set_regdom(const struct ieee80211_re
 /* Caller must hold cfg80211_drv_mutex */
 void reg_device_remove(struct wiphy *wiphy)
 {
-	if (!last_request->wiphy)
+	if (!last_request || !last_request->wiphy)
 		return;
 	if (last_request->wiphy != wiphy)
 		return;



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cfg80211: fix wiphy remove if no regulatory request
  2008-12-01 11:07 [PATCH] cfg80211: fix wiphy remove if no regulatory request Johannes Berg
@ 2008-12-01 19:01 ` Luis R. Rodriguez
  2008-12-01 19:34   ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2008-12-01 19:01 UTC (permalink / raw)
  To: Johannes Berg; +Cc: John Linville, linux-wireless

On Mon, Dec 1, 2008 at 3:07 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> Fixes the segfault I just pointed out.

Thanks, the commit log should include the panic I guess though right?

  Luis

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cfg80211: fix wiphy remove if no regulatory request
  2008-12-01 19:01 ` Luis R. Rodriguez
@ 2008-12-01 19:34   ` Johannes Berg
  0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2008-12-01 19:34 UTC (permalink / raw)
  To: Luis R. Rodriguez; +Cc: John Linville, linux-wireless

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

On Mon, 2008-12-01 at 11:01 -0800, Luis R. Rodriguez wrote:
> On Mon, Dec 1, 2008 at 3:07 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > Fixes the segfault I just pointed out.
> 
> Thanks, the commit log should include the panic I guess though right?

Maybe, maybe not, it's fairly clear what's going on from the diff, I
think.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-12-01 19:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-01 11:07 [PATCH] cfg80211: fix wiphy remove if no regulatory request Johannes Berg
2008-12-01 19:01 ` Luis R. Rodriguez
2008-12-01 19:34   ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox