Re: [PATCH] mac80211: Print unknown packet type in tasklet_handler

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

On Wed, 2008-12-17 at 14:26 -0600, Larry Finger wrote:
> In stress testing p54usb, the WARN_ON() in ieee80211_tasklet_handler() was
> triggered; however, there is no logging of the received value for packet
> type. Adding that feature will improve the warning.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
> 
> John.
> 
> This is 2.6.29 material.
> 
> Larry
> ---
> 
> Index: wireless-testing/net/mac80211/main.c
> ===================================================================
> --- wireless-testing.orig/net/mac80211/main.c
> +++ wireless-testing/net/mac80211/main.c
> @@ -341,7 +341,8 @@ static void ieee80211_tasklet_handler(un
>  			dev_kfree_skb(skb);
>  			break ;
>  		default:
> -			WARN_ON(1);
> +			WARN(1, "mac80211: Packet is of unknown type %d\n",
> +			     skb->pkt_type);
>  			dev_kfree_skb(skb);
>  			break;
>  		}
> 

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]