* [PATCH] mac80211: Print unknown packet type in tasklet_handler
@ 2008-12-17 20:26 Larry Finger
2008-12-18 15:23 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2008-12-17 20:26 UTC (permalink / raw)
To: John W Linville, Johannes Berg; +Cc: linux-wireless
In stress testing p54usb, the WARN_ON() in ieee80211_tasklet_handler() was
triggered; however, there is no logging of the received value for packet
type. Adding that feature will improve the warning.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John.
This is 2.6.29 material.
Larry
---
Index: wireless-testing/net/mac80211/main.c
===================================================================
--- wireless-testing.orig/net/mac80211/main.c
+++ wireless-testing/net/mac80211/main.c
@@ -341,7 +341,8 @@ static void ieee80211_tasklet_handler(un
dev_kfree_skb(skb);
break ;
default:
- WARN_ON(1);
+ WARN(1, "mac80211: Packet is of unknown type %d\n",
+ skb->pkt_type);
dev_kfree_skb(skb);
break;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mac80211: Print unknown packet type in tasklet_handler
2008-12-17 20:26 [PATCH] mac80211: Print unknown packet type in tasklet_handler Larry Finger
@ 2008-12-18 15:23 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2008-12-18 15:23 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On Wed, 2008-12-17 at 14:26 -0600, Larry Finger wrote:
> In stress testing p54usb, the WARN_ON() in ieee80211_tasklet_handler() was
> triggered; however, there is no logging of the received value for packet
> type. Adding that feature will improve the warning.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>
> John.
>
> This is 2.6.29 material.
>
> Larry
> ---
>
> Index: wireless-testing/net/mac80211/main.c
> ===================================================================
> --- wireless-testing.orig/net/mac80211/main.c
> +++ wireless-testing/net/mac80211/main.c
> @@ -341,7 +341,8 @@ static void ieee80211_tasklet_handler(un
> dev_kfree_skb(skb);
> break ;
> default:
> - WARN_ON(1);
> + WARN(1, "mac80211: Packet is of unknown type %d\n",
> + skb->pkt_type);
> dev_kfree_skb(skb);
> break;
> }
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-18 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-12-17 20:26 [PATCH] mac80211: Print unknown packet type in tasklet_handler Larry Finger
2008-12-18 15:23 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox