Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH 3/4] iwlwifi: another led naming fix
@ 2009-01-31 14:52 Danny Kukawka
  2009-02-02 18:59 ` reinette chatre
  0 siblings, 1 reply; 2+ messages in thread
From: Danny Kukawka @ 2009-01-31 14:52 UTC (permalink / raw)
  To: linux-wireless; +Cc: Helmut Schaa, reinette chatre

From: Danny Kukawka <dkukawka@suse.de>
Subject: iwlwifi: another led naming fix

Fixed led device naming for the iwlwifi (iwl-3945) driver. Due 
to the documentation of the led subsystem/class the naming should 
be "devicename:colour:function" while not applying sections
should be left blank.
    
This should lead to e.g. "iwl-%s::RX" instead of "iwl-%s:RX".

Signed-off-by: Danny Kukawka <dkukawka@suse.de>
--
 iwl-led.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/iwlwifi/iwl-3945-led.c b/drivers/net/wireless/iwlwifi/iwl-3945-led.c
index 4c63890..09f9350 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945-led.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945-led.c
@@ -317,7 +317,7 @@ int iwl3945_led_register(struct iwl3945_priv *priv)
 
 	trigger = ieee80211_get_radio_led_name(priv->hw);
 	snprintf(priv->led[IWL_LED_TRG_RADIO].name,
-		 sizeof(priv->led[IWL_LED_TRG_RADIO].name), "iwl-%s:radio",
+		 sizeof(priv->led[IWL_LED_TRG_RADIO].name), "iwl-%s::radio",
 		 wiphy_name(priv->hw->wiphy));
 
 	priv->led[IWL_LED_TRG_RADIO].led_on = iwl3945_led_on;
@@ -333,7 +333,7 @@ int iwl3945_led_register(struct iwl3945_priv *priv)
 
 	trigger = ieee80211_get_assoc_led_name(priv->hw);
 	snprintf(priv->led[IWL_LED_TRG_ASSOC].name,
-		 sizeof(priv->led[IWL_LED_TRG_ASSOC].name), "iwl-%s:assoc",
+		 sizeof(priv->led[IWL_LED_TRG_ASSOC].name), "iwl-%s::assoc",
 		 wiphy_name(priv->hw->wiphy));
 
 	ret = iwl3945_led_register_led(priv,
@@ -350,7 +350,7 @@ int iwl3945_led_register(struct iwl3945_priv *priv)
 
 	trigger = ieee80211_get_rx_led_name(priv->hw);
 	snprintf(priv->led[IWL_LED_TRG_RX].name,
-		 sizeof(priv->led[IWL_LED_TRG_RX].name), "iwl-%s:RX",
+		 sizeof(priv->led[IWL_LED_TRG_RX].name), "iwl-%s::RX",
 		 wiphy_name(priv->hw->wiphy));
 
 	ret = iwl3945_led_register_led(priv,
@@ -366,7 +366,7 @@ int iwl3945_led_register(struct iwl3945_priv *priv)
 
 	trigger = ieee80211_get_tx_led_name(priv->hw);
 	snprintf(priv->led[IWL_LED_TRG_TX].name,
-		 sizeof(priv->led[IWL_LED_TRG_TX].name), "iwl-%s:TX",
+		 sizeof(priv->led[IWL_LED_TRG_TX].name), "iwl-%s::TX",
 		 wiphy_name(priv->hw->wiphy));
 
 	ret = iwl3945_led_register_led(priv,

-- 
Danny Kukawka
dkukawka@suse.de
R&D Team Mobile Devices
SUSE LINUX a Novell Business
Maxfeldstr. 5, D-90409 Nuernberg, Germany
SUSE LINUX Products GmbH, Nuernberg; GF: Markus Rex, HRB 16746 (AG Nuernberg)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/4] iwlwifi: another led naming fix
  2009-01-31 14:52 [PATCH 3/4] iwlwifi: another led naming fix Danny Kukawka
@ 2009-02-02 18:59 ` reinette chatre
  0 siblings, 0 replies; 2+ messages in thread
From: reinette chatre @ 2009-02-02 18:59 UTC (permalink / raw)
  To: Danny Kukawka; +Cc: linux-wireless@vger.kernel.org, Helmut Schaa

On Sat, 2009-01-31 at 06:52 -0800, Danny Kukawka wrote:
> From: Danny Kukawka <dkukawka@suse.de>
> Subject: iwlwifi: another led naming fix
> 
> Fixed led device naming for the iwlwifi (iwl-3945) driver. Due 
> to the documentation of the led subsystem/class the naming should 
> be "devicename:colour:function" while not applying sections
> should be left blank.
>     
> This should lead to e.g. "iwl-%s::RX" instead of "iwl-%s:RX".
> 
> Signed-off-by: Danny Kukawka <dkukawka@suse.de>

Thank you

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-02-02 18:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-31 14:52 [PATCH 3/4] iwlwifi: another led naming fix Danny Kukawka
2009-02-02 18:59 ` reinette chatre

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox