Linux wireless drivers development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Dan Williams <dcbw@redhat.com>
Cc: Samuel Ortiz <samuel@sortiz.org>,
	John Linville <linville@tuxdriver.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC] mac80211: Filter scan results
Date: Thu, 05 Feb 2009 00:19:46 +0100	[thread overview]
Message-ID: <1233789586.5559.12.camel@californication> (raw)
In-Reply-To: <1233763752.21577.10.camel@localhost.localdomain>

Hi Dan,

> > In very dense environment, the scan result buffer can get really large, mostly
> > due to the addition of proprietary IEs. iwlist fails, typically warning about:
> > "print_scanning_info: Allocation failed". wpa_supplicant fails as well, after
> > reallocating the scan result buffer several times, up to 132 Kbytes:
> > 	[snip]
> > 	Scan results did not fit - trying larger buffer (131072 bytes)
> > 	ioctl[SIOCGIWSCAN]: Argument list too long
> > 
> > By adding a mac80211 module parameter, we can filter the scan results and keep
> > only the ones userspace currently worries about, i.e. WPA1, WPA2, WMM and WPS.
> > 
> > To activate this feature, 1 has to be written to
> > /sys/module/mac80211/parameters/ieee80211_scan_ie_filter
> 
> NAK.  Use cfg80211.  Module parameters are the wrong way to work around
> API limitations; the API gets fixed or replaced instead.  Furthermore,
> the stack/drivers should *NOT* be filtering scan results at all.  That's
> the job of the userspace program requesting the results; otherwise
> passive listeners will get only filtered results, and not the complete
> scan list.

yes, yes and yes, but reality is a little bit different here. You are
not able to get the results out of the kernel because WEXT is just
braindead.

Regards

Marcel



  reply	other threads:[~2009-02-04 23:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 15:08 [PATCH RFC] mac80211: Filter scan results Samuel Ortiz
2009-02-04 15:10 ` Johannes Berg
2009-02-04 23:18   ` Marcel Holtmann
2009-02-04 23:20     ` Dan Williams
2009-02-04 23:29       ` Marcel Holtmann
2009-02-04 23:31     ` Johannes Berg
2009-02-04 16:09 ` Dan Williams
2009-02-04 23:19   ` Marcel Holtmann [this message]
2009-02-04 23:22     ` Dan Williams
2009-02-04 23:23 ` Dan Williams
2009-02-04 23:35   ` Johannes Berg
2009-02-05  8:44     ` Jouni Malinen
2009-02-05  9:52       ` Jouni Malinen
2009-02-05 11:44         ` Tomas Winkler
2009-02-05 12:12           ` Jouni Malinen
2009-02-05 13:00             ` Tomas Winkler
2009-02-05 14:57               ` Dan Williams
2009-02-05 15:36                 ` Tomas Winkler
2009-02-05 11:10       ` Jouni Malinen
2009-02-05 11:55         ` Johannes Berg
2009-02-05 12:07           ` Jouni Malinen
2009-02-05 12:10             ` Johannes Berg
2009-02-05 12:26               ` Jouni Malinen
2009-02-05 22:42                 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233789586.5559.12.camel@californication \
    --to=marcel@holtmann.org \
    --cc=dcbw@redhat.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox