Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Marcel Holtmann <holtmann@linux.intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Samuel Ortiz <samuel@sortiz.org>,
	John Linville <linville@tuxdriver.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC] mac80211: Filter scan results
Date: Wed, 04 Feb 2009 18:20:57 -0500	[thread overview]
Message-ID: <1233789657.24227.14.camel@localhost.localdomain> (raw)
In-Reply-To: <1233789496.5559.10.camel@californication>

On Thu, 2009-02-05 at 00:18 +0100, Marcel Holtmann wrote:
> Hi Johannes,
> 
> > > In very dense environment, the scan result buffer can get really large, mostly
> > > due to the addition of proprietary IEs. iwlist fails, typically warning about:
> > > "print_scanning_info: Allocation failed". wpa_supplicant fails as well, after
> > > reallocating the scan result buffer several times, up to 132 Kbytes:
> > > 	[snip]
> > > 	Scan results did not fit - trying larger buffer (131072 bytes)
> > > 	ioctl[SIOCGIWSCAN]: Argument list too long
> > > 
> > > By adding a mac80211 module parameter, we can filter the scan results and keep
> > > only the ones userspace currently worries about, i.e. WPA1, WPA2, WMM and WPS.
> > > 
> > > To activate this feature, 1 has to be written to
> > > /sys/module/mac80211/parameters/ieee80211_scan_ie_filter
> > 
> > Module parameter, hard-coded filter, just to work around wext crap. Eww.
> > NACK.
> 
> we are perfectly aware that this is ugly and trust me, that nobody of us
> wants to do it. However we do have these setups and they happen in real
> life. I have been in a couple of locations where I ran into this problem
> and in that cases there is no way for me to establish any kind of WiFi
> connection at all, because the buffers are just too small. And that is
> with a laptop. Then just think about a mobile phone running mac80211
> where the memory is limited.
> 
> So WEXT is crap and everybody agrees, but until we can use cfg80211 for
> scanning, we need something to make this work. So if this patch is not

No.  This does not go into the kernel.  Help make cfg80211 work for you,
and you're perfectly free to patch your kernels as you see fit.  You can
certainly backport cfg80211 scanning bits to whatever kernels you care
about, just the same as you'd backport this hack to whatever kernels you
care about.

Dan



  reply	other threads:[~2009-02-04 23:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 15:08 [PATCH RFC] mac80211: Filter scan results Samuel Ortiz
2009-02-04 15:10 ` Johannes Berg
2009-02-04 23:18   ` Marcel Holtmann
2009-02-04 23:20     ` Dan Williams [this message]
2009-02-04 23:29       ` Marcel Holtmann
2009-02-04 23:31     ` Johannes Berg
2009-02-04 16:09 ` Dan Williams
2009-02-04 23:19   ` Marcel Holtmann
2009-02-04 23:22     ` Dan Williams
2009-02-04 23:23 ` Dan Williams
2009-02-04 23:35   ` Johannes Berg
2009-02-05  8:44     ` Jouni Malinen
2009-02-05  9:52       ` Jouni Malinen
2009-02-05 11:44         ` Tomas Winkler
2009-02-05 12:12           ` Jouni Malinen
2009-02-05 13:00             ` Tomas Winkler
2009-02-05 14:57               ` Dan Williams
2009-02-05 15:36                 ` Tomas Winkler
2009-02-05 11:10       ` Jouni Malinen
2009-02-05 11:55         ` Johannes Berg
2009-02-05 12:07           ` Jouni Malinen
2009-02-05 12:10             ` Johannes Berg
2009-02-05 12:26               ` Jouni Malinen
2009-02-05 22:42                 ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233789657.24227.14.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=holtmann@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=reinette.chatre@intel.com \
    --cc=samuel@sortiz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox