Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, marcel@holtmann.org,
	kalle.valo@nokia.com, kyle@mcmartin.ca,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/5] cfg80211: Add AP beacon regulatory hints
Date: Fri, 20 Feb 2009 18:06:50 +0100	[thread overview]
Message-ID: <1235149610.4023.76.camel@johannes.local> (raw)
In-Reply-To: <1235109874-3966-4-git-send-email-lrodriguez@atheros.com>

[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]

On Fri, 2009-02-20 at 01:04 -0500, Luis R. Rodriguez wrote:

> +/**
> + * regulatory_hint_found_beacon - hints a beacon was found on a channel
> + * @wiphy: the wireless device where the beacon was found on
> + * @beacon_chan: the channel on which the beacon was found on
> + * @gfp: context flags
> + *
> + * This informs the wireless core that a beacon from an AP was found on
> + * the channel provided. This allows the wireless core to make educated
> + * guesses on regulatory to help with world roaming. This is only used for
> + * world roaming -- when we do not know our current location. This is
> + * only useful on channels 12, 13 and 14 on the 2 GHz band as all other
> + * channels are already enabled by the world regulatory domain (channels
> + * 1-11); and on non-radar 5 GHz channels.
> + */
> +extern int regulatory_hint_found_beacon(struct wiphy *wiphy,
> +					struct ieee80211_channel *beacon_chan,
> +					gfp_t gfp);

Remove the extern please; also, you don't need to export this function
in a public header file, reg.h should be fine.

johannes


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2009-02-20 17:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-20  6:04 [PATCH 0/5] cfg80211: enhance world roaming Luis R. Rodriguez
2009-02-20  6:04 ` [PATCH 1/5] cfg80211: enable active-scan / beaconing on Ch 1-11 for world regdom Luis R. Rodriguez
2009-02-20 19:59   ` Gábor Stefanik
2009-02-20 20:08     ` Luis R. Rodriguez
2009-02-20  6:04 ` [PATCH 2/5] cfg80211: enable 5 GHz world roaming channels Luis R. Rodriguez
2009-02-20  6:04 ` [PATCH 3/5] cfg80211: Add AP beacon regulatory hints Luis R. Rodriguez
2009-02-20 17:06   ` Johannes Berg [this message]
2009-02-20 20:34     ` Luis R. Rodriguez
2009-02-20  6:04 ` [PATCH 4/5] ath9k: follow beacon hints on reg_notifier when world roaming Luis R. Rodriguez
2009-02-20  6:04 ` [PATCH 5/5] cfg80211: default OLD_REG to n Luis R. Rodriguez
2009-02-20  6:08 ` [PATCH 0/5] cfg80211: enhance world roaming Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235149610.4023.76.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=kalle.valo@nokia.com \
    --cc=kyle@mcmartin.ca \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox