Re: [PATCH 3/5] cfg80211: Add AP beacon regulatory hints

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Fri, Feb 20, 2009 at 9:06 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2009-02-20 at 01:04 -0500, Luis R. Rodriguez wrote:
>
>> +/**
>> + * regulatory_hint_found_beacon - hints a beacon was found on a channel
>> + * @wiphy: the wireless device where the beacon was found on
>> + * @beacon_chan: the channel on which the beacon was found on
>> + * @gfp: context flags
>> + *
>> + * This informs the wireless core that a beacon from an AP was found on
>> + * the channel provided. This allows the wireless core to make educated
>> + * guesses on regulatory to help with world roaming. This is only used for
>> + * world roaming -- when we do not know our current location. This is
>> + * only useful on channels 12, 13 and 14 on the 2 GHz band as all other
>> + * channels are already enabled by the world regulatory domain (channels
>> + * 1-11); and on non-radar 5 GHz channels.
>> + */
>> +extern int regulatory_hint_found_beacon(struct wiphy *wiphy,
>> +                                     struct ieee80211_channel *beacon_chan,
>> +                                     gfp_t gfp);
>
> Remove the extern please; also, you don't need to export this function
> in a public header file, reg.h should be fine.

Ah that's right your new scan stuff ensures even cfg80211 drivers
benefit from all this already. Sweet, will change it.

  Luis