[PATCH] mac80211: Notify the driver only when the beacon interval changes

[PATCH] mac80211: Notify the driver only when the beacon interval changes

[Sujith]

Currently, the driver is unconditionally notified of beacon
interval. This is a problem in AP mode, because the driver has
to know that the beacon interval has actualy changed to recalculate
TBTT and reset the HW TSF. Fix this to make mac80211 notify the driver
only when the beacon interval has been reconfigured to a new value.

Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
---

( CC the list properly this time. )

 net/mac80211/cfg.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
index c43129e..58693e5 100644
--- a/net/mac80211/cfg.c
+++ b/net/mac80211/cfg.c
@@ -451,7 +451,8 @@ static int ieee80211_config_beacon(struct ieee80211_sub_if_data *sdata,
 	 * This is a kludge. beacon interval should really be part
 	 * of the beacon information.
 	 */
-	if (params->interval) {
+	if (params->interval && (sdata->local->hw.conf.beacon_int !=
+				 params->interval)) {
 		sdata->local->hw.conf.beacon_int = params->interval;
 		err = ieee80211_hw_config(sdata->local,
 					IEEE80211_CONF_CHANGE_BEACON_INTERVAL);
-- 
1.6.1

Re: [PATCH] mac80211: Notify the driver only when the beacon interval changes

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]

On Fri, 2009-02-27 at 09:49 +0530, Sujith wrote:
> Currently, the driver is unconditionally notified of beacon
> interval. This is a problem in AP mode, because the driver has
> to know that the beacon interval has actualy changed to recalculate
> TBTT and reset the HW TSF. Fix this to make mac80211 notify the driver
> only when the beacon interval has been reconfigured to a new value.
> 
> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
> 
> ( CC the list properly this time. )
> 
>  net/mac80211/cfg.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index c43129e..58693e5 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -451,7 +451,8 @@ static int ieee80211_config_beacon(struct ieee80211_sub_if_data *sdata,
>  	 * This is a kludge. beacon interval should really be part
>  	 * of the beacon information.
>  	 */
> -	if (params->interval) {
> +	if (params->interval && (sdata->local->hw.conf.beacon_int !=
> +				 params->interval)) {
>  		sdata->local->hw.conf.beacon_int = params->interval;
>  		err = ieee80211_hw_config(sdata->local,
>  					IEEE80211_CONF_CHANGE_BEACON_INTERVAL);

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]