From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni.malinen@atheros.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix WMM ACM parsing and AC downgrade operation
Date: Sun, 08 Mar 2009 13:28:07 +0100 [thread overview]
Message-ID: <1236515287.4205.11.camel@johannes.local> (raw)
In-Reply-To: <20090305152346.GA30029@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 745 bytes --]
On Thu, 2009-03-05 at 17:23 +0200, Jouni Malinen wrote:
> @@ -99,10 +99,13 @@ static u16 classify80211(struct ieee8021
> /* in case we are a client verify acm is not set for this ac */
> while (unlikely(local->wmm_acm & BIT(skb->priority))) {
> if (wme_downgrade_ac(skb)) {
> - /* The old code would drop the packet in this
> - * case.
> + /*
> + * This should not really happen. The AP has marked all
> + * lower ACs to require admission control which is not
> + * a reasonable configuration. Allow the frame to be
> + * transmitted using AC_BK as a workaround.
> */
> - return 0;
> + break;
It seems to me that return 0 here was incorrect, or wme_downgrade_ac
needs changes?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-08 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 15:23 [PATCH] mac80211: Fix WMM ACM parsing and AC downgrade operation Jouni Malinen
2009-03-08 12:28 ` Johannes Berg [this message]
2009-03-08 14:17 ` Jouni Malinen
2009-03-08 14:25 ` Johannes Berg
2009-03-08 17:59 ` Jouni Malinen
2009-03-08 19:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236515287.4205.11.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox