From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Jouni Malinen <jouni.malinen@atheros.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix WMM ACM parsing and AC downgrade operation
Date: Sun, 08 Mar 2009 20:02:59 +0100 [thread overview]
Message-ID: <1236538979.4205.63.camel@johannes.local> (raw)
In-Reply-To: <20090308175914.GA18800@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On Sun, 2009-03-08 at 19:59 +0200, Jouni Malinen wrote:
> > Sorry, I meant correct. Why is it not correct? wme_downgrade_ac doesn't
> > modify the skb when it returns an error.
>
> Ah, okay, that's a more sensible comment and I can even try to provide a
> more useful reply after having understood your point ;-).
[snip]
Ok, yes, that makes a lot more sense now that I see your comments and
the code, and your fix does seem correct to me now after having
understood it :)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-03-08 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-05 15:23 [PATCH] mac80211: Fix WMM ACM parsing and AC downgrade operation Jouni Malinen
2009-03-08 12:28 ` Johannes Berg
2009-03-08 14:17 ` Jouni Malinen
2009-03-08 14:25 ` Johannes Berg
2009-03-08 17:59 ` Jouni Malinen
2009-03-08 19:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236538979.4205.63.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=jouni.malinen@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox