Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH] mac80211: Fix TKIP/WEP HT capability handling
@ 2009-03-02  7:58 Sujith
  2009-03-08 12:41 ` Johannes Berg
  0 siblings, 1 reply; 2+ messages in thread
From: Sujith @ 2009-03-02  7:58 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless, johannes, Jouni.Malinen

There is no need to parse the AP's HT capabilities if
the STA uses TKIP/WEP cipher. This allows the rate control
module to choose the correct(legacy) rate table.

Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
---
 net/mac80211/mlme.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 7f23858..52d876e 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -1307,7 +1307,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
 	else
 		sdata->flags &= ~IEEE80211_SDATA_OPERATING_GMODE;
 
-	if (elems.ht_cap_elem)
+	/* If TKIP/WEP is used, no need to parse AP's HT capabilities */
+	if (elems.ht_cap_elem && !(ifmgd->flags & IEEE80211_STA_TKIP_WEP_USED))
 		ieee80211_ht_cap_ie_to_sta_ht_cap(sband,
 				elems.ht_cap_elem, &sta->sta.ht_cap);
 
-- 
1.6.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mac80211: Fix TKIP/WEP HT capability handling
  2009-03-02  7:58 [PATCH] mac80211: Fix TKIP/WEP HT capability handling Sujith
@ 2009-03-08 12:41 ` Johannes Berg
  0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2009-03-08 12:41 UTC (permalink / raw)
  To: Sujith; +Cc: linville, linux-wireless, Jouni.Malinen

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Mon, 2009-03-02 at 13:28 +0530, Sujith wrote:
> There is no need to parse the AP's HT capabilities if
> the STA uses TKIP/WEP cipher. This allows the rate control
> module to choose the correct(legacy) rate table.
> 
> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
>  net/mac80211/mlme.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 7f23858..52d876e 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -1307,7 +1307,8 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
>  	else
>  		sdata->flags &= ~IEEE80211_SDATA_OPERATING_GMODE;
>  
> -	if (elems.ht_cap_elem)
> +	/* If TKIP/WEP is used, no need to parse AP's HT capabilities */
> +	if (elems.ht_cap_elem && !(ifmgd->flags & IEEE80211_STA_TKIP_WEP_USED))
>  		ieee80211_ht_cap_ie_to_sta_ht_cap(sband,
>  				elems.ht_cap_elem, &sta->sta.ht_cap);
>  

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-08 12:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-02  7:58 [PATCH] mac80211: Fix TKIP/WEP HT capability handling Sujith
2009-03-08 12:41 ` Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox