From: Johannes Berg <johannes@sipsolutions.net>
To: Sujith <m.sujith@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>
Subject: Re: ath9k fragmentation
Date: Fri, 13 Mar 2009 10:03:04 +0100 [thread overview]
Message-ID: <1236934984.25931.48.camel@johannes.local> (raw)
In-Reply-To: <18873.48952.353253.595670@gargle.gargle.HOWL> (sfid-20090313_030441_815758_BD575074)
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Fri, 2009-03-13 at 07:34 +0530, Sujith wrote:
> Sequence number handling is pretty much borked in ath9k.
> There is a comment in assign_aggr_tid_seqno@xmit.c - and it doesn't make much sense.
Indeed, that doesn't seem to reflect the code at all.
> Removing all crappy code in ath9k dealing with this and leaving everything
> to mac80211 would certainly be the better option, but we still have to figure
> out how to manage BA windows.
Can you explain a little what is required?
For ampdu_action(), I recently saw something, somewhere, saying
"mac80211 expects us to fill in the seqno variable" or so, but this is
only true if you don't use mac80211's sequence numbers, otherwise it is
fine to leave it at the pre-assigned value.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2009-03-13 9:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 18:10 ath9k fragmentation Johannes Berg
2009-03-13 2:04 ` Sujith
2009-03-13 6:01 ` Sujith
2009-03-13 9:03 ` Johannes Berg [this message]
2009-03-13 10:48 ` Sujith
2009-03-13 10:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236934984.25931.48.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=m.sujith@gmail.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox