From: Sujith <Sujith.Manoharan@atheros.com>
To: Sujith <m.sujith@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>
Subject: Re: ath9k fragmentation
Date: Fri, 13 Mar 2009 11:31:20 +0530 [thread overview]
Message-ID: <18873.63152.836875.231557@gargle.gargle.HOWL> (raw)
In-Reply-To: <18873.48952.353253.595670@gargle.gargle.HOWL>
Sujith wrote:
> Johannes Berg wrote:
> > Just a quick note -- was testing fragmentation and happened to use ath9k
> > as the test station, this failed utterly, it sent increasing sequence
> > numbers and no fragment number.
>
> Sequence number handling is pretty much borked in ath9k.
> There is a comment in assign_aggr_tid_seqno@xmit.c - and it doesn't make much sense.
> Removing all crappy code in ath9k dealing with this and leaving everything
> to mac80211 would certainly be the better option, but we still have to figure
> out how to manage BA windows.
>
And a quick hack to fix this would be to not increment the internal sequence
number when the frame is fragmented. But that is what it would be, a hack. :)
Sujith
next prev parent reply other threads:[~2009-03-13 6:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 18:10 ath9k fragmentation Johannes Berg
2009-03-13 2:04 ` Sujith
2009-03-13 6:01 ` Sujith [this message]
2009-03-13 9:03 ` Johannes Berg
2009-03-13 10:48 ` Sujith
2009-03-13 10:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18873.63152.836875.231557@gargle.gargle.HOWL \
--to=sujith.manoharan@atheros.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=m.sujith@gmail.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox