Re: [RFC PATCH v3 5/5] mac80211: add beacon filtering support

Re: [RFC PATCH v3 5/5] mac80211: add beacon filtering support

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

On Sat, 2009-03-21 at 14:09 +0200, Kalle Valo wrote:

> +/**
> + * ieee80211_beacon_loss - inform hardware does not receive beacons
> + *
> + * @hw: pointer as obtained from ieee80211_alloc_hw()
> + * @vif: &struct ieee80211_vif pointer from &struct ieee80211_if_init_conf.
> + *
> + * When beacon filtering is enabled with IEEE80211_HW_BEACON_FILTERING and
> + * IEEE80211_CONF_PS is set, the driver needs to inform whenever the
> + * hardware is not receiving beacons with this function.
> + */
> +void ieee80211_beacon_loss(struct ieee80211_hw *hw,
> +			   struct ieee80211_vif *vif);

Strictly speaking there's no need to pass both since the mac80211 sdata
can be obtained from vif and that has a pointer to local, but it doesn't
really matter.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [RFC PATCH v3 0/5] mac80211: beacon filtering

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On Sat, 2009-03-21 at 14:08 +0200, Kalle Valo wrote:
> Here's my proposal how to implement beacon filtering in mac80211. The
> basic idea is simple, the driver enables filtering whenever mac80211
> enables power save and the driver calls ieee80211_beacon_loss()
> whenever hardware informs about beacon loss.
> 
> I have tested this with stlc45xx (with beacon filtering) and iwl3945
> (without beacon filtering) and based on simple tests this seems to
> work. For reference I'll send the stlc45xx patch as a followup.

Looks good to me.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]