From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: Kalle Valo <Kalle.Valo@nokia.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH 2.6.30] cfg80211: copy hold when replacing BSS
Date: Thu, 16 Apr 2009 12:15:38 +0200 [thread overview]
Message-ID: <1239876938.9737.14.camel@johannes.local> (raw)
When we receive a probe response frame we can replace the
BSS struct in our list -- but if that struct is held then
we need to hold the new one as well.
We really should fix this completely and not replace the
struct, but this is a bandaid for now.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/wireless/scan.c | 2 ++
1 file changed, 2 insertions(+)
--- wireless-testing.orig/net/wireless/scan.c 2009-04-16 12:12:08.000000000 +0200
+++ wireless-testing/net/wireless/scan.c 2009-04-16 12:12:21.000000000 +0200
@@ -364,6 +364,8 @@ cfg80211_bss_update(struct cfg80211_regi
list_replace(&found->list, &res->list);
rb_replace_node(&found->rbn, &res->rbn,
&dev->bss_tree);
+ /* XXX: workaround */
+ res->hold = found->hold;
kref_put(&found->ref, bss_release);
found = res;
} else if (found) {
reply other threads:[~2009-04-16 10:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239876938.9737.14.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=Kalle.Valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox