public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.6.30] cfg80211: copy hold when replacing BSS
@ 2009-04-16 10:15 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-04-16 10:15 UTC (permalink / raw)
  To: John Linville; +Cc: Kalle Valo, linux-wireless

When we receive a probe response frame we can replace the
BSS struct in our list -- but if that struct is held then
we need to hold the new one as well.

We really should fix this completely and not replace the
struct, but this is a bandaid for now.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/wireless/scan.c |    2 ++
 1 file changed, 2 insertions(+)

--- wireless-testing.orig/net/wireless/scan.c	2009-04-16 12:12:08.000000000 +0200
+++ wireless-testing/net/wireless/scan.c	2009-04-16 12:12:21.000000000 +0200
@@ -364,6 +364,8 @@ cfg80211_bss_update(struct cfg80211_regi
 		list_replace(&found->list, &res->list);
 		rb_replace_node(&found->rbn, &res->rbn,
 				&dev->bss_tree);
+		/* XXX: workaround */
+		res->hold = found->hold;
 		kref_put(&found->ref, bss_release);
 		found = res;
 	} else if (found) {



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-16 10:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-16 10:15 [PATCH 2.6.30] cfg80211: copy hold when replacing BSS Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox