* Re: [PATCH v2] mac80211: fix beacon loss detection after scan
[not found] <20090419054719.16621.48938.stgit@tikku>
@ 2009-04-19 8:11 ` Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-04-19 8:11 UTC (permalink / raw)
To: Kalle Valo; +Cc: John W.Linville, Jaswinder Singh Rajput, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
On Sun, 2009-04-19 at 08:47 +0300, Kalle Valo wrote:
> Currently beacon loss detection triggers after a scan. A probe request
> is sent and a message like this is printed to the log:
>
> wlan0: beacon loss from AP 00:12:17:e7:98:de - sending probe request
>
> But in fact there is no beacon loss, the beacons are just not received
> because of the ongoing scan. Fix it by updating last_beacon after
> the scan has finished.
>
> Reported-by: Jaswinder Singh Rajput <jaswinder@kernel.org>
> Signed-off-by: Kalle Valo <kalle.valo@iki.fi>
Thanks.
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
>
> net/mac80211/mlme.c | 10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index c0f91d5..1b8509d 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2005,9 +2005,17 @@ static void ieee80211_sta_work(struct work_struct *work)
>
> static void ieee80211_restart_sta_timer(struct ieee80211_sub_if_data *sdata)
> {
> - if (sdata->vif.type == NL80211_IFTYPE_STATION)
> + if (sdata->vif.type == NL80211_IFTYPE_STATION) {
> + /*
> + * Need to update last_beacon to avoid beacon loss
> + * test to trigger.
> + */
> + sdata->u.mgd.last_beacon = jiffies;
> +
> +
> queue_work(sdata->local->hw.workqueue,
> &sdata->u.mgd.work);
> + }
> }
>
> /* interface setup */
>
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] only message in thread