* [PATCH] rndis_wlan: remove nickname support
@ 2009-04-20 13:17 Johannes Berg
2009-04-20 19:13 ` Jussi Kivilinna
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2009-04-20 13:17 UTC (permalink / raw)
To: John Linville; +Cc: Jussi Kivilinna, linux-wireless
Supporting wireless extension nickname is pointless
and no other modern driver supports this, so remove
it.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/rndis_wlan.c | 38 --------------------------------------
1 file changed, 38 deletions(-)
--- wireless-testing.orig/drivers/net/wireless/rndis_wlan.c 2009-04-20 15:11:25.000000000 +0200
+++ wireless-testing/drivers/net/wireless/rndis_wlan.c 2009-04-20 15:11:45.000000000 +0200
@@ -372,9 +372,6 @@ struct rndis_wext_private {
struct iw_statistics iwstats;
struct iw_statistics privstats;
- int nick_len;
- char nick[32];
-
int caps;
int multicast_size;
@@ -1798,39 +1795,6 @@ static int rndis_iw_get_frag(struct net_
}
-static int rndis_iw_set_nick(struct net_device *dev,
- struct iw_request_info *info, union iwreq_data *wrqu, char *extra)
-{
- struct usbnet *usbdev = netdev_priv(dev);
- struct rndis_wext_private *priv = get_rndis_wext_priv(usbdev);
-
- devdbg(usbdev, "SIOCSIWNICK");
-
- priv->nick_len = wrqu->data.length;
- if (priv->nick_len > 32)
- priv->nick_len = 32;
-
- memcpy(priv->nick, extra, priv->nick_len);
- return 0;
-}
-
-
-static int rndis_iw_get_nick(struct net_device *dev,
- struct iw_request_info *info, union iwreq_data *wrqu, char *extra)
-{
- struct usbnet *usbdev = netdev_priv(dev);
- struct rndis_wext_private *priv = get_rndis_wext_priv(usbdev);
-
- wrqu->data.flags = 1;
- wrqu->data.length = priv->nick_len;
- memcpy(extra, priv->nick, priv->nick_len);
-
- devdbg(usbdev, "SIOCGIWNICK: '%s'", priv->nick);
-
- return 0;
-}
-
-
static int rndis_iw_set_freq(struct net_device *dev,
struct iw_request_info *info, union iwreq_data *wrqu, char *extra)
{
@@ -2039,8 +2003,6 @@ static const iw_handler rndis_iw_handler
IW_IOCTL(SIOCGIWSCAN) = (iw_handler) cfg80211_wext_giwscan,
IW_IOCTL(SIOCSIWESSID) = rndis_iw_set_essid,
IW_IOCTL(SIOCGIWESSID) = rndis_iw_get_essid,
- IW_IOCTL(SIOCSIWNICKN) = rndis_iw_set_nick,
- IW_IOCTL(SIOCGIWNICKN) = rndis_iw_get_nick,
IW_IOCTL(SIOCGIWRATE) = rndis_iw_get_rate,
IW_IOCTL(SIOCSIWRTS) = rndis_iw_set_rts,
IW_IOCTL(SIOCGIWRTS) = rndis_iw_get_rts,
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rndis_wlan: remove nickname support
2009-04-20 13:17 [PATCH] rndis_wlan: remove nickname support Johannes Berg
@ 2009-04-20 19:13 ` Jussi Kivilinna
0 siblings, 0 replies; 2+ messages in thread
From: Jussi Kivilinna @ 2009-04-20 19:13 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
Quoting "Johannes Berg" <johannes@sipsolutions.net>:
> Supporting wireless extension nickname is pointless
> and no other modern driver supports this, so remove
> it.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-20 19:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-20 13:17 [PATCH] rndis_wlan: remove nickname support Johannes Berg
2009-04-20 19:13 ` Jussi Kivilinna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox