From: Johannes Berg <johannes@sipsolutions.net>
To: reinette chatre <reinette.chatre@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: WARN on return of ieee80211_if_config
Date: Mon, 20 Apr 2009 23:06:14 +0200 [thread overview]
Message-ID: <1240261574.4632.22.camel@johannes.local> (raw)
In-Reply-To: <1240261096.5206.107.camel@rc-desk>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Mon, 2009-04-20 at 13:58 -0700, reinette chatre wrote:
> > Or will this test:
> > if (!iwl_is_alive(priv))
> > return -EAGAIN;
> >
> > kick us out before even getting to the rfkill test?
>
> Yes ... and it is not immediately clear that it is caused by rfkill. The
> STATUS_ALIVE bit that is tested here is cleared when machine is
> suspended. When machine is resumed and HW rfkill is set then it will not
> come up fully, see __iwl_up() that returns early with success if rfkill
> is enabled. STATUS_ALIVE will only be set again after HW rfkill is
> disabled and we initialize ucode again.
Ok... Very confusing. Can you change the patch to have a comment that
this should also be changed back when rfkill is integrated with
mac80211? Maybe I'll even do that for .31.
Thanks,
Johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-04-20 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 18:31 WARN on return of ieee80211_if_config reinette chatre
2009-04-20 18:35 ` Johannes Berg
2009-04-20 20:58 ` reinette chatre
2009-04-20 21:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240261574.4632.22.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox