public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mac80211: fix IBSS code to not sleep while atomic
@ 2009-04-20 22:30 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-04-20 22:30 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

With the RCU locking here we sleep while in an atomic context,
since we can sleep just use mutex locking for the interface
list instead of RCU. Sorry, seems I didn't get that in my UML
test.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
 net/mac80211/ibss.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- wireless-testing.orig/net/mac80211/ibss.c	2009-04-21 00:28:44.000000000 +0200
+++ wireless-testing/net/mac80211/ibss.c	2009-04-21 00:28:45.000000000 +0200
@@ -784,14 +784,14 @@ void ieee80211_ibss_notify_scan_complete
 {
 	struct ieee80211_sub_if_data *sdata;
 
-	rcu_read_lock();
-	list_for_each_entry_rcu(sdata, &local->interfaces, list) {
+	mutex_lock(&local->iflist_mtx);
+	list_for_each_entry(sdata, &local->interfaces, list) {
 		if (sdata->vif.type != NL80211_IFTYPE_ADHOC)
 			continue;
 		sdata->u.ibss.last_scan_completed = jiffies;
 		ieee80211_sta_find_ibss(sdata);
 	}
-	rcu_read_unlock();
+	mutex_unlock(&local->iflist_mtx);
 }
 
 ieee80211_rx_result



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-04-20 22:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-20 22:30 [PATCH] mac80211: fix IBSS code to not sleep while atomic Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox