Re: 2.6.30-rc3: iwlagn probe timeouts (regression)

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

On Tue, 2009-04-28 at 22:58 +0200, Niel Lambrechts wrote:

> >> Apr 27 01:33:43 linux-7vph kernel: wlan0: direct probe to AP
> >> 00:1d:92:1d:1e:8e timed out

(etc)
 
> Okidoki, I've managed to bisect it:
> 
> commit 47afbaf5af9454a7a1a64591e20cbfcc27ca67a8
> Author: Johannes Berg <johannes@sipsolutions.net>
> Date:   Tue Apr 7 15:22:28 2009 +0200
> 
>     mac80211: correct wext transmit power handler

Ok, that's confusing. It doesn't even change any code that is normally
executed, at least not significantly since local->user_power_level is
usually 0; checking
	if (local->user_power_level)
vs. checking
	if (local->user_power_level >= 0)
shouldn't make a difference in that case (although I admit that I forgot
a few cases in that commit, will fix).

Can you please verify that the code behaves correctly if you revert just
this commit? Unless you're playing with "iwconfig wlan0 txpower .." I
don't see a reason for this to cause a problem.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]