From: Johannes Berg <johannes@sipsolutions.net>
To: Niel Lambrechts <niel.lambrechts@gmail.com>
Cc: reinette chatre <reinette.chatre@intel.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: 2.6.30-rc3: iwlagn probe timeouts (regression)
Date: Wed, 29 Apr 2009 10:28:08 +0200 [thread overview]
Message-ID: <1240993688.593.16.camel@johannes.local> (raw)
In-Reply-To: <49F78F40.1060904@gmail.com> (sfid-20090429_012115_069726_86F3227D)
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Wed, 2009-04-29 at 01:20 +0200, Niel Lambrechts wrote:
> Thanks for the help, reverting the commit did indeed fix things for me -
> I tested that earlier this evening with the latest git kernel...
Ok, thanks.
> > Scratch that, try this patch instead. Sorry, stupid mistake! mac80211
> > never asks the driver to set a txpower level, and keeps the variable set
> > to 0, but the driver looks at it anyway. Bug on both accounts, I guess,
> > but mac80211 should set the variable and tell the driver anyway.
> >
> and so does your patch, although I had to patch by hand, as my version
> of the file still looked like this:
>
> local->hw.conf.long_frame_max_tx_count = 4;
> local->hw.conf.short_frame_max_tx_count = 7;
> local->hw.conf.radio_enabled = true;
> + local->user_power_level = -1;
>
> Can I more or less bargain that this fix will make in in time before the
> final 2.6.30 kernel is released?
Yes. Thanks for testing that too. I'm sorry that it was such a stupid
bug and you spent so much time hunting it.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2009-04-29 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 0:00 2.6.30-rc3: iwlagn probe timeouts (regression) Niel Lambrechts
2009-04-27 17:19 ` reinette chatre
2009-04-28 20:58 ` Niel Lambrechts
2009-04-28 21:42 ` Johannes Berg
2009-04-28 21:47 ` Johannes Berg
2009-04-28 23:20 ` Niel Lambrechts
2009-04-29 8:28 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240993688.593.16.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=niel.lambrechts@gmail.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox