* [PATCH] iwlwifi: make iwl_set_rate static
@ 2009-05-08 8:53 Johannes Berg
2009-05-08 17:31 ` [PATCH v2] " Johannes Berg
2009-05-08 17:32 ` [PATCH] " reinette chatre
0 siblings, 2 replies; 5+ messages in thread
From: Johannes Berg @ 2009-05-08 8:53 UTC (permalink / raw)
To: John Linville; +Cc: reinette chatre, linux-wireless
It's not needed elsewhere.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl-core.c | 2 +-
drivers/net/wireless/iwlwifi/iwl-core.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:52:20.000000000 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:52:24.000000000 +0200
@@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl
u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv);
-void iwl_set_rate(struct iwl_priv *priv);
-
u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx);
static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 10:52:20.000000000 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 10:52:24.000000000 +0200
@@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc
}
EXPORT_SYMBOL(iwl_connection_init_rx_config);
-void iwl_set_rate(struct iwl_priv *priv)
+static void iwl_set_rate(struct iwl_priv *priv)
{
const struct ieee80211_supported_band *hw = NULL;
struct ieee80211_rate *rate;
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] iwlwifi: make iwl_set_rate static
2009-05-08 8:53 [PATCH] iwlwifi: make iwl_set_rate static Johannes Berg
@ 2009-05-08 17:31 ` Johannes Berg
2009-05-08 17:47 ` reinette chatre
2009-05-08 17:32 ` [PATCH] " reinette chatre
1 sibling, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2009-05-08 17:31 UTC (permalink / raw)
To: John Linville; +Cc: reinette chatre, linux-wireless
It's not needed outside iwl-core.c
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
drivers/net/wireless/iwlwifi/iwl-core.c | 3 +--
drivers/net/wireless/iwlwifi/iwl-core.h | 2 --
2 files changed, 1 insertion(+), 4 deletions(-)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:53:34.000000000 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 19:30:16.000000000 +0200
@@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl
u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv);
-void iwl_set_rate(struct iwl_priv *priv);
-
u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx);
static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
--- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 13:48:01.000000000 +0200
+++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 19:30:21.000000000 +0200
@@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc
}
EXPORT_SYMBOL(iwl_connection_init_rx_config);
-void iwl_set_rate(struct iwl_priv *priv)
+static void iwl_set_rate(struct iwl_priv *priv)
{
const struct ieee80211_supported_band *hw = NULL;
struct ieee80211_rate *rate;
@@ -1170,7 +1170,6 @@ void iwl_set_rate(struct iwl_priv *priv)
priv->staging_rxon.ofdm_basic_rates =
(IWL_OFDM_BASIC_RATES_MASK >> IWL_FIRST_OFDM_RATE) & 0xFF;
}
-EXPORT_SYMBOL(iwl_set_rate);
void iwl_rx_csa(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
{
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] iwlwifi: make iwl_set_rate static
2009-05-08 17:31 ` [PATCH v2] " Johannes Berg
@ 2009-05-08 17:47 ` reinette chatre
0 siblings, 0 replies; 5+ messages in thread
From: reinette chatre @ 2009-05-08 17:47 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
On Fri, 2009-05-08 at 10:31 -0700, Johannes Berg wrote:
> It's not needed outside iwl-core.c
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-core.c | 3 +--
> drivers/net/wireless/iwlwifi/iwl-core.h | 2 --
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:53:34.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 19:30:16.000000000 +0200
> @@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl
>
> u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv);
>
> -void iwl_set_rate(struct iwl_priv *priv);
> -
> u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx);
>
> static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 13:48:01.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 19:30:21.000000000 +0200
> @@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc
> }
> EXPORT_SYMBOL(iwl_connection_init_rx_config);
>
> -void iwl_set_rate(struct iwl_priv *priv)
> +static void iwl_set_rate(struct iwl_priv *priv)
> {
> const struct ieee80211_supported_band *hw = NULL;
> struct ieee80211_rate *rate;
> @@ -1170,7 +1170,6 @@ void iwl_set_rate(struct iwl_priv *priv)
> priv->staging_rxon.ofdm_basic_rates =
> (IWL_OFDM_BASIC_RATES_MASK >> IWL_FIRST_OFDM_RATE) & 0xFF;
> }
> -EXPORT_SYMBOL(iwl_set_rate);
>
> void iwl_rx_csa(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
> {
>
>
Thank you
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iwlwifi: make iwl_set_rate static
2009-05-08 8:53 [PATCH] iwlwifi: make iwl_set_rate static Johannes Berg
2009-05-08 17:31 ` [PATCH v2] " Johannes Berg
@ 2009-05-08 17:32 ` reinette chatre
2009-05-08 17:30 ` Johannes Berg
1 sibling, 1 reply; 5+ messages in thread
From: reinette chatre @ 2009-05-08 17:32 UTC (permalink / raw)
To: Johannes Berg; +Cc: John Linville, linux-wireless
Hi Johannes,
On Fri, 2009-05-08 at 01:53 -0700, Johannes Berg wrote:
> It's not needed elsewhere.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> drivers/net/wireless/iwlwifi/iwl-core.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-core.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:52:20.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.h 2009-05-08 10:52:24.000000000 +0200
> @@ -363,8 +363,6 @@ int iwl_hwrate_to_plcp_idx(u32 rate_n_fl
>
> u8 iwl_rate_get_lowest_plcp(struct iwl_priv *priv);
>
> -void iwl_set_rate(struct iwl_priv *priv);
> -
> u8 iwl_toggle_tx_ant(struct iwl_priv *priv, u8 ant_idx);
>
> static inline u32 iwl_ant_idx_to_flags(u8 ant_idx)
> --- wireless-testing.orig/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 10:52:20.000000000 +0200
> +++ wireless-testing/drivers/net/wireless/iwlwifi/iwl-core.c 2009-05-08 10:52:24.000000000 +0200
> @@ -1124,7 +1124,7 @@ void iwl_connection_init_rx_config(struc
> }
> EXPORT_SYMBOL(iwl_connection_init_rx_config);
>
> -void iwl_set_rate(struct iwl_priv *priv)
> +static void iwl_set_rate(struct iwl_priv *priv)
> {
> const struct ieee80211_supported_band *hw = NULL;
> struct ieee80211_rate *rate;
>
>
To make this complete, could you please also remove the EXPORT_SYMBOL of
this function and also its declaration in iwl-core.h?
Thank you
Reinette
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-05-08 17:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-08 8:53 [PATCH] iwlwifi: make iwl_set_rate static Johannes Berg
2009-05-08 17:31 ` [PATCH v2] " Johannes Berg
2009-05-08 17:47 ` reinette chatre
2009-05-08 17:32 ` [PATCH] " reinette chatre
2009-05-08 17:30 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox