[PATCH 1/18 v2] mac80211: disable moving between PS modes during scan

[PATCH 1/18 v2] mac80211: disable moving between PS modes during scan

[Luis R. Rodriguez]

We don't want to trigger moving between PS mode during
scan. With this enabled we sometimes end up sending nullfunc
frames during scan. We're supposed to only send one prior to
scan and after scan.

This fixes an oops which occured due to an assert in ath9k:

http://marc.info/?l=linux-wireless&m=124277331319024

The assert was happening because the rate control algorithm
figures it should find at least one valid dual stream or
single stream rate. Since we allow mac80211 to send nullfunc
frames during scan and dynamic PS was enabled at times we ended
up trying to send nullfunc frames for the target sta on the
wrong band for which we have no valid rate to communicate with
it. This brakes the assumptions in rate control. We'll handle
this sanity check next, but this fix does prevent the
spurious nullfunc frames from actually being sent.

We determine we also need to disable moving between PS modes
when not associated so lets just add that now as well.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---

While testing when I was sleep walking I noticed I couldn't switch
to a different AP. The new changes here fixed that.

I'm not seeing any more strange deadbeef stuff with this series now.

 net/mac80211/tx.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 1aed88d..e0a4e06 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1415,7 +1415,9 @@ int ieee80211_master_start_xmit(struct sk_buff *skb, struct net_device *dev)
 	}
 
 	if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
-	    local->hw.conf.dynamic_ps_timeout > 0) {
+	    local->hw.conf.dynamic_ps_timeout > 0 &&
+	    !local->sw_scanning && !local->hw_scanning && local->ps_sdata &&
+	    (local->ps_sdata->u.mgd.flags & IEEE80211_STA_ASSOCIATED)) {
 		if (local->hw.conf.flags & IEEE80211_CONF_PS) {
 			ieee80211_stop_queues_by_reason(&local->hw,
 					IEEE80211_QUEUE_STOP_REASON_PS);
-- 
1.5.6.3

[PATCH 1/18 v3] mac80211: disable moving between PS modes during scan

[Johannes Berg]

From: "Luis R. Rodriguez" <lrodriguez@atheros.com>

We don't want to trigger moving between PS mode during scan,
because then we will sometimes end up sending nullfunc frames
during scan. We're supposed to only send one prior to scan
and after scan.

This fixes an oops which occured due to an assert in ath9k:

http://marc.info/?l=linux-wireless&m=124277331319024

The assert was happening because the rate control algorithm
figures it should find at least one valid dual stream or
single stream rate. Since we allow mac80211 to send nullfunc
frames during scan and dynamic PS was enabled at times we ended
up trying to send nullfunc frames for the target sta on the
wrong band for which we have no valid rate to communicate with
it. This breaks the assumptions in rate control.

We determine we also need to disable moving between PS modes
when not associated so lets just add that now as well, and we
should not have a ps_sdata when that interface cannot actually
go into PS because it's not associated.

Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---

While testing when I was sleep walking I noticed I couldn't switch
to a different AP. The new changes here fixed that.

I'm not seeing any more strange deadbeef stuff with this series now.

 net/mac80211/mlme.c |    6 ++----
 net/mac80211/tx.c   |    3 ++-
 2 files changed, 4 insertions(+), 5 deletions(-)

--- wireless-testing.orig/net/mac80211/tx.c	2009-06-09 23:13:34.000000000 +0200
+++ wireless-testing/net/mac80211/tx.c	2009-06-10 14:58:32.000000000 +0200
@@ -1415,7 +1415,8 @@ int ieee80211_master_start_xmit(struct s
 	}
 
 	if ((local->hw.flags & IEEE80211_HW_PS_NULLFUNC_STACK) &&
-	    local->hw.conf.dynamic_ps_timeout > 0) {
+	    local->hw.conf.dynamic_ps_timeout > 0 &&
+	    !local->sw_scanning && !local->hw_scanning && local->ps_sdata) {
 		if (local->hw.conf.flags & IEEE80211_CONF_PS) {
 			ieee80211_stop_queues_by_reason(&local->hw,
 					IEEE80211_QUEUE_STOP_REASON_PS);
--- wireless-testing.orig/net/mac80211/mlme.c	2009-06-10 14:58:36.000000000 +0200
+++ wireless-testing/net/mac80211/mlme.c	2009-06-10 15:15:41.000000000 +0200
@@ -621,9 +621,6 @@ static void ieee80211_change_ps(struct i
 	struct ieee80211_conf *conf = &local->hw.conf;
 
 	if (local->ps_sdata) {
-		if (!(local->ps_sdata->u.mgd.flags & IEEE80211_STA_ASSOCIATED))
-			return;
-
 		ieee80211_enable_ps(local, local->ps_sdata);
 	} else if (conf->flags & IEEE80211_CONF_PS) {
 		conf->flags &= ~IEEE80211_CONF_PS;
@@ -653,7 +650,8 @@ void ieee80211_recalc_ps(struct ieee8021
 		count++;
 	}
 
-	if (count == 1 && found->u.mgd.powersave) {
+	if (count == 1 && found->u.mgd.powersave &&
+	    (found->u.mgd.flags & IEEE80211_STA_ASSOCIATED)) {
 		s32 beaconint_us;
 
 		if (latency < 0)