* [PATCH] mac80211: tell SME about real auth state
@ 2009-06-24 20:06 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-06-24 20:06 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
When the auth algorithm is rejected, but we don't have
another one to try, we will eventually retry but that
isn't useful -- we'll then do it again and again until
we eventually give up. Instead, we should let the SME
know and go into disabled state. The same applies for
situations where the AP rejects with any other status
code.
Additionally, when trying the next auth algorithm, we
should reset the auth_tries so that just a single lost
frame doesn't lead to us giving up on the third auth
algorithm.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/mac80211/mlme.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
--- wireless-testing.orig/net/mac80211/mlme.c 2009-06-24 22:03:04.000000000 +0200
+++ wireless-testing/net/mac80211/mlme.c 2009-06-24 22:03:38.000000000 +0200
@@ -1511,9 +1511,15 @@ static void ieee80211_rx_mgmt_auth(struc
!ieee80211_sta_wep_configured(sdata))
continue;
ifmgd->auth_alg = algs[pos];
- break;
+ ifmgd->auth_tries = 0;
+ return;
}
}
+ /* nothing else to try -- give up */
+ cfg80211_send_rx_auth(sdata->dev, (u8 *) mgmt, len,
+ GFP_KERNEL);
+ ifmgd->state = IEEE80211_STA_MLME_DISABLED;
+ ieee80211_recalc_idle(sdata->local);
return;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-06-24 20:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-24 20:06 [PATCH] mac80211: tell SME about real auth state Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox