Linux wireless drivers development
 help / color / mirror / Atom feed
* [PATCH 2.6.31] cfg80211: fix refcount leak
@ 2009-07-02 13:46 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-07-02 13:46 UTC (permalink / raw)
  To: John Linville; +Cc: linux-wireless

The code in cfg80211's cfg80211_bss_update erroneously
grabs a reference to the BSS, which means that it will
never be freed.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: stable@kernel.org [2.6.29, 2.6.30]
---
 net/wireless/scan.c |    1 -
 1 file changed, 1 deletion(-)

--- wireless-testing.orig/net/wireless/scan.c	2009-07-02 15:32:12.000000000 +0200
+++ wireless-testing/net/wireless/scan.c	2009-07-02 15:39:23.000000000 +0200
@@ -376,7 +376,6 @@ cfg80211_bss_update(struct cfg80211_regi
 	found = rb_find_bss(dev, res);
 
 	if (found) {
-		kref_get(&found->ref);
 		found->pub.beacon_interval = res->pub.beacon_interval;
 		found->pub.tsf = res->pub.tsf;
 		found->pub.signal = res->pub.signal;



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-02 13:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-02 13:46 [PATCH 2.6.31] cfg80211: fix refcount leak Johannes Berg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox