* [PATCH] cfg80211: fix two buglets
@ 2009-07-07 21:46 Johannes Berg
0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2009-07-07 21:46 UTC (permalink / raw)
To: John Linville; +Cc: linux-wireless
This fixes two small bugs:
1) the connect variable is already initialised, and the
assignment to auth_type overwrites the previous setting
with a wrong value
2) when all authentication attempts fail, we need to report
that we couldn't connect
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
net/wireless/nl80211.c | 4 ----
net/wireless/sme.c | 5 ++---
2 files changed, 2 insertions(+), 7 deletions(-)
--- wireless-testing.orig/net/wireless/nl80211.c 2009-07-07 23:39:04.000000000 +0200
+++ wireless-testing/net/wireless/nl80211.c 2009-07-07 23:39:05.000000000 +0200
@@ -3695,10 +3695,6 @@ static int nl80211_connect(struct sk_buf
wiphy = &rdev->wiphy;
- connect.bssid = NULL;
- connect.channel = NULL;
- connect.auth_type = NL80211_AUTHTYPE_OPEN_SYSTEM;
-
if (info->attrs[NL80211_ATTR_MAC])
connect.bssid = nla_data(info->attrs[NL80211_ATTR_MAC]);
connect.ssid = nla_data(info->attrs[NL80211_ATTR_SSID]);
--- wireless-testing.orig/net/wireless/sme.c 2009-07-07 23:39:01.000000000 +0200
+++ wireless-testing/net/wireless/sme.c 2009-07-07 23:39:05.000000000 +0200
@@ -296,9 +296,8 @@ void cfg80211_sme_rx_auth(struct net_dev
wdev->conn->state = CFG80211_CONN_AUTHENTICATE_NEXT;
schedule_work(&rdev->conn_work);
} else if (status_code != WLAN_STATUS_SUCCESS) {
- wdev->sme_state = CFG80211_SME_IDLE;
- kfree(wdev->conn);
- wdev->conn = NULL;
+ __cfg80211_connect_result(dev, mgmt->bssid, NULL, 0, NULL, 0,
+ status_code, false);
} else if (wdev->sme_state == CFG80211_SME_CONNECTING &&
wdev->conn->state == CFG80211_CONN_AUTHENTICATING) {
wdev->conn->state = CFG80211_CONN_ASSOCIATE_NEXT;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-07-07 21:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-07 21:46 [PATCH] cfg80211: fix two buglets Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox