* [PATCH 41/44] includecheck fix: include/linux, rfkill.h [not found] <1247063308.4382.12.camel@ht.satnam> @ 2009-07-08 15:55 ` Jaswinder Singh Rajput 2009-07-08 19:32 ` Marcel Holtmann 0 siblings, 1 reply; 4+ messages in thread From: Jaswinder Singh Rajput @ 2009-07-08 15:55 UTC (permalink / raw) To: johannes, linux-wireless, Andrew Morton, Sam Ravnborg, LKML fix the following 'make includecheck' warning: include/linux/rfkill.h: linux/types.h is included more than once. Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> --- include/linux/rfkill.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h index e73e242..2ce2983 100644 --- a/include/linux/rfkill.h +++ b/include/linux/rfkill.h @@ -99,7 +99,6 @@ enum rfkill_user_states { #undef RFKILL_STATE_UNBLOCKED #undef RFKILL_STATE_HARD_BLOCKED -#include <linux/types.h> #include <linux/kernel.h> #include <linux/list.h> #include <linux/mutex.h> -- 1.6.0.6 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h 2009-07-08 15:55 ` [PATCH 41/44] includecheck fix: include/linux, rfkill.h Jaswinder Singh Rajput @ 2009-07-08 19:32 ` Marcel Holtmann 2009-07-09 4:01 ` Jaswinder Singh Rajput 0 siblings, 1 reply; 4+ messages in thread From: Marcel Holtmann @ 2009-07-08 19:32 UTC (permalink / raw) To: Jaswinder Singh Rajput Cc: johannes, linux-wireless, Andrew Morton, Sam Ravnborg, LKML Hi Jaswinder, > fix the following 'make includecheck' warning: > > include/linux/rfkill.h: linux/types.h is included more than once. > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > --- > include/linux/rfkill.h | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h > index e73e242..2ce2983 100644 > --- a/include/linux/rfkill.h > +++ b/include/linux/rfkill.h > @@ -99,7 +99,6 @@ enum rfkill_user_states { > #undef RFKILL_STATE_UNBLOCKED > #undef RFKILL_STATE_HARD_BLOCKED > > -#include <linux/types.h> > #include <linux/kernel.h> > #include <linux/list.h> > #include <linux/mutex.h> with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems correct. Regards Marcel ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h 2009-07-08 19:32 ` Marcel Holtmann @ 2009-07-09 4:01 ` Jaswinder Singh Rajput 2009-07-09 5:47 ` Marcel Holtmann 0 siblings, 1 reply; 4+ messages in thread From: Jaswinder Singh Rajput @ 2009-07-09 4:01 UTC (permalink / raw) To: Marcel Holtmann Cc: johannes, linux-wireless, Andrew Morton, Sam Ravnborg, LKML Hello Marcel, On Wed, 2009-07-08 at 12:32 -0700, Marcel Holtmann wrote: > Hi Jaswinder, > > > fix the following 'make includecheck' warning: > > > > include/linux/rfkill.h: linux/types.h is included more than once. > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > --- > > include/linux/rfkill.h | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h > > index e73e242..2ce2983 100644 > > --- a/include/linux/rfkill.h > > +++ b/include/linux/rfkill.h > > @@ -99,7 +99,6 @@ enum rfkill_user_states { > > #undef RFKILL_STATE_UNBLOCKED > > #undef RFKILL_STATE_HARD_BLOCKED > > > > -#include <linux/types.h> > > #include <linux/kernel.h> > > #include <linux/list.h> > > #include <linux/mutex.h> > > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems > correct. > ACK or Reviewed-by ? Thanks, -- JSR ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h 2009-07-09 4:01 ` Jaswinder Singh Rajput @ 2009-07-09 5:47 ` Marcel Holtmann 0 siblings, 0 replies; 4+ messages in thread From: Marcel Holtmann @ 2009-07-09 5:47 UTC (permalink / raw) To: Jaswinder Singh Rajput Cc: johannes, linux-wireless, Andrew Morton, Sam Ravnborg, LKML Hi Jaswinder, > > > fix the following 'make includecheck' warning: > > > > > > include/linux/rfkill.h: linux/types.h is included more than once. > > > > > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com> > > > --- > > > include/linux/rfkill.h | 1 - > > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h > > > index e73e242..2ce2983 100644 > > > --- a/include/linux/rfkill.h > > > +++ b/include/linux/rfkill.h > > > @@ -99,7 +99,6 @@ enum rfkill_user_states { > > > #undef RFKILL_STATE_UNBLOCKED > > > #undef RFKILL_STATE_HARD_BLOCKED > > > > > > -#include <linux/types.h> > > > #include <linux/kernel.h> > > > #include <linux/list.h> > > > #include <linux/mutex.h> > > > > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems > > correct. > > > > ACK or Reviewed-by ? both if you want to, but John already picked it up for wireless-testing if I am not mistaken. So it is on its way into 2.6.32 somehow. Regards Marcel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-07-09 5:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1247063308.4382.12.camel@ht.satnam>
2009-07-08 15:55 ` [PATCH 41/44] includecheck fix: include/linux, rfkill.h Jaswinder Singh Rajput
2009-07-08 19:32 ` Marcel Holtmann
2009-07-09 4:01 ` Jaswinder Singh Rajput
2009-07-09 5:47 ` Marcel Holtmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox